Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57015

Change incorrect skip by preventResetByRollback()

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Run against the 5 databases (mysql, mariadb, postgres, mssql and oracle):

      vendor/bin/phpunit tool_lpmigrate_framework_processor_testcase \
          admin/tool/lpmigrate/tests/processor_test.php
      

      Verify they pass WITHOUT any skipped.

      Show
      Run against the 5 databases (mysql, mariadb, postgres, mssql and oracle): vendor/bin/phpunit tool_lpmigrate_framework_processor_testcase \ admin/tool/lpmigrate/tests/processor_test.php Verify they pass WITHOUT any skipped.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Because some parts of tool/lpmigrate use transactions internally, it clashes with the transactions used by both postgresql and sqlserver to provide quicker resets between tests.

      Right now the code in the tests simply skips them, but that's incorrect and, instead, preventResetByRollback() should be used, in order to allow those databases to perform slower reset, keeping transactions available for the tests using them.

      So this just changes the current skip (that is both not-needed and annoying when trying to get 100% passes) by a correct phpunit api use.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              David Monllaó
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/17