Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57015

Change incorrect skip by preventResetByRollback()

XMLWordPrintable

    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_31_STABLE
    • Hide

      Run against the 5 databases (mysql, mariadb, postgres, mssql and oracle):

      vendor/bin/phpunit tool_lpmigrate_framework_processor_testcase \
      		 
          admin/tool/lpmigrate/tests/processor_test.php

      Verify they pass WITHOUT any skipped.

      Show
      Run against the 5 databases (mysql, mariadb, postgres, mssql and oracle): vendor/bin/phpunit tool_lpmigrate_framework_processor_testcase \ admin/tool/lpmigrate/tests/processor_test.php Verify they pass WITHOUT any skipped.

      Because some parts of tool/lpmigrate use transactions internally, it clashes with the transactions used by both postgresql and sqlserver to provide quicker resets between tests.

      Right now the code in the tests simply skips them, but that's incorrect and, instead, preventResetByRollback() should be used, in order to allow those databases to perform slower reset, keeping transactions available for the tests using them.

      So this just changes the current skip (that is both not-needed and annoying when trying to get 100% passes) by a correct phpunit api use.

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Rajesh Taneja Rajesh Taneja
            David Monllaó David Monllaó
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.