Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57020

Unable to delete scales which are no longer used

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Below are the steps I have done for testing:

      1. Using mdk created students, teachers and enrolled them in a new course
      2. Created a new scale by navigating to "Site Administration" -> "Grades" -> "Scale", checked the "Standard scale", and filled the mandatory fields along with the description. Added only one word "Like" to the "Scale" field.
      3. Edited the course as a teacher, and created a forum with the following settings:
        a. Added a forum name
        b. Edited "Whole forum grading", selected "Grade" as "Scale" and pointed to the new Scale created in step 2.
        c. Edited "Ratings" as "Average of ratings". Select the "Scale" pointing to the scale created in step 2.
      4. Now as admin/teacher navigate to Dashboard -> Courses -> Course Name -> Grades -> Grade administration -> Scales. You should not be able to see the trash icon for the scale as it is in use.
      5. Edit the forum to and in the Ratings section select Aggregate type to "No Ratings".
      6. Edit the forum to change the "whole forum grading" to "None".
      7. Now as admin/teacher navigate to Dashboard -> Courses -> Course Name -> Grades -> Grade administration -> Scales. You should be able to see the trash icon for the scale as it is not in use.

       

      Show
      Below are the steps I have done for testing: Using mdk created students, teachers and enrolled them in a new course Created a new scale by navigating to "Site Administration" -> "Grades" -> "Scale", checked the "Standard scale", and filled the mandatory fields along with the description. Added only one word "Like" to the "Scale" field. Edited the course as a teacher, and created a forum with the following settings: a. Added a forum name b. Edited "Whole forum grading", selected "Grade" as "Scale" and pointed to the new Scale created in step 2. c. Edited "Ratings" as "Average of ratings". Select the "Scale" pointing to the scale created in step 2. Now as admin/teacher navigate to Dashboard -> Courses -> Course Name -> Grades -> Grade administration -> Scales. You should not be able to see the trash icon for the scale as it is in use. Edit the forum to and in the Ratings section select Aggregate type to "No Ratings". Edit the forum to change the "whole forum grading" to "None". Now as admin/teacher navigate to Dashboard -> Courses -> Course Name -> Grades -> Grade administration -> Scales. You should be able to see the trash icon for the scale as it is not in use.  
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
      MDL-57020-39-allow_delete_unused_scale
    • Pull 3.10 Branch:
      MDL-57020-310-allow_delete_unused_scale
    • Pull 3.11 Branch:
      MDL-57020-311-allow_delete_unused_scale
    • Pull Master Branch:
      MDL-57020-master-allow_delete_unused_scale
    • Story Points:
      5
    • Sprint:
      4.0 holding pattern 11

      Description

      Steps to reproduce:

      1. Login as a teacher and create a single-item scale in the course e.g. 'Like'.
      2. Create a forum and enable the single-item scale, setting the aggregate type to 'Average of ratings'.
      3. Rate some posts in the forum.
      4. After rating a post, click on the rating link and check that the popup window correctly displays the name of the user who rated the post, the rating and the time.
      5. Check that it is possible to remove a rating.
      6. Go to the gradebook and check that the ratings are listed correctly.
      7. Check that the single-item scale cannot be deleted from the Scales page, as it is in use.
      8. Update the forum and set the aggregate type to 'No rating'.

      Check that the single-item scale shows it is being used and cannot be deleted, whereas it is not used anywhere now.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sujith Sujith Haridasan
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Mathew May
              Integrator:
              Adrian Greeve
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              3 Vote for this issue
              Watchers:
              15 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Mar/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 5 hours, 35 minutes
                  1d 5h 35m