Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57036

The profile on the messaging UI does not show the profile picture

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as a student.
      2. Click on 'Messages' in the user menu.
      3. Click on the 'Contacts' tab.
      4. Search for a user that has a profile picture.
      5. Click on the user you searched for.
      6. Ensure their picture is shown on the profile panel as well.
      Show
      Log in as a student. Click on 'Messages' in the user menu. Click on the 'Contacts' tab. Search for a user that has a profile picture. Click on the user you searched for. Ensure their picture is shown on the profile panel as well.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57036_master

      Description

      We show it everywhere.

      The old messaging behaviour did not use user_get_user_details() to check whether or not the user could see the profile picture, so it was always shown. If we were to use user_get_user_details() 99.9% of users would never ever see a profile picture on the messaging interface, making it useless. The reason is because of the following conditional check if (!$currentuser && !$canviewdetailscap && !has_coursecontact_role($user->id)) {.

      So, to keep things consistent, let's show it.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16