Loading...

XML

Word

Printable

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Main Branch:
~~MDL-57063~~-master
Pull Main Diff URL:
https://github.com/FMCorz/moodle/compare/30cfed3731...MDL-57063-master
Testing Instructions:
Hide

Navigate to Site administration ► Competencies ► Competency settings.

Uncheck Enable competencies.

Click Save changes.

Navigate back to the course.

Backup the course

Confirm that

the competency option does not appear during the backup

there isn't any error during the process (note ~~MDL-57064~~)

Also backup the course using the CLI backup tool

php admin/cli/backup.php --courseid=ID

you should not see any error or notice

Repeat the lot with competencies enabled, only this time the competency option will appear during the web backup
Show
Navigate to Site administration ► Competencies ► Competency settings. Uncheck Enable competencies. Click Save changes. Navigate back to the course. Backup the course Confirm that the competency option does not appear during the backup there isn't any error during the process (note MDL-57064 ) Also backup the course using the CLI backup tool php admin/cli/backup.php --courseid=ID you should not see any error or notice Repeat the lot with competencies enabled , only this time the competency option will appear during the web backup

Steps to reproduce:

Try backup and you will observe

Debug info:

Error code: setting_locked_by_config

$a contents:

×Stack trace:

line 170 of /backup/util/settings/base_setting.class.php: base_setting_exception thrown

line 632 of /backup/util/dbops/backup_controller_dbops.class.php: call to base_setting->set_value()

line 569 of /backup/util/dbops/backup_controller_dbops.class.php: call to backup_controller_dbops::apply_admin_config_defaults()

line 372 of /backup/controller/backup_controller.class.php: call to backup_controller_dbops::apply_config_defaults()

line 133 of /backup/controller/backup_controller.class.php: call to backup_controller->apply_defaults()

line 88 of /backup/backup.php: call to backup_controller->__construct()

Discovered while testing

MDLQA-10348 CLONE - User can opt out of competency backup during backups

Testing discovered

MDL-57064 Undefined property $competencies when competencies are disabled

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Frédéric Massart, Mark Nelson, Rajesh Taneja