Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57074

Filepicker: Link icon should be on the right side of the File icon, in RTL mode (Theme:Boost)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Please test in Boost (32/master) and clean (all) and with all major browsers

      Test prerequisites

      1. You must have 2 courses
      2. You must have the hebrew language pack or other RTL language pack installed.

      This tests uses a folder resource to test the filemanager icon styles. In order to generate the required (link,alias) icons, some pre-test steps need to be carried out.

      Folder set up (in English/LTR)

      1. In the first course, create a single file resource (any file type that can be accepted is fine).
      2. In the second course, create a folder resource
      3. Edit the folder resource and add a alias to a file like so:
        • Click 'Add file'
        • On the left pane, select 'Sever files'
        • Find the file you created in the first course. Click it but don't proceed yet.
        • In the dialog, make sure to check the box next to 'Create an alias/shortcut to the file' and then proceed to add the file.
      4. Now, add another file from your local filesystem to the folder.
      5. Add a subfolder to the folder.
      6. You should now have 2 files in the folder (one alias, one real file) and one subfolder. Save the folder now.
      7. Now, back in course 1 create a folder resource.
      8. Edit the folder resource and add an alias to the real file in course 2 like so:
        • Click 'Add file'
        • On the left pane, select 'Sever files'
        • Find the file you created within the folder in the second course. Click it but don't proceed yet.
        • In the dialog, make sure to check the box next to 'Create an alias/shortcut to the file' and then proceed to add the file.
      9. Save the folder.
      10. Now, edit the folder in course 2 again (default view):
      11. Confirm that:
        • You see 2 files and one subfolder in the folder
        • One file has an alias icon (arrow) in the bottom left corner.
        • The other file has a link icon (chain link) in the bottom right corner.
        • The folder has an edit icon on the bottom right corner.
      • If you don't see the above icons, check again, as we'll need this as the starting point for the test below.

      Testing views (English/LTR)

      1. Edit the folder in course 2.
      2. Change the view to 'File details'
      3. Confirm that:
        • The alias icon is aligned to the bottom left of its respective file icon.
        • The link icon is aligned to the bottom right of its respective file icon.
        • The edit subfolder icon is aligned to the bottom right of its respective subfolder.
      4. Change the view to 'File tree'
      5. Confirm that the above three conditions are also true
        Boost only step
      6. Resize the window to less than 400 pixels wide (when the open drawer will overlap content, rather than sitting inline)
      7. Open the drawer
      8. For each of the view modes, toggle the drawer and Confirm that the alias and link icons are not visible behind the drawer (no z-index problems).

      Testing views (Hebrew/RTL)

      1. Edit the folder in course 2.
      2. Change the language to Hebrew or other RTL
      3. Ensure view is 'File icons'
      4. Confirm that:
        • The alias icon is aligned to the bottom right of its respective file icon and points towards the file icon.
        • The link icon is aligned to the bottom left of its respective file icon.
        • The edit subfolder icon is aligned to the bottom left of its respective subfolder.
      5. Change the view to 'File details'
      6. Confirm the above three conditions are also true
      7. Change the view to 'File tree'
      8. Confirm the above three conditions are also true
        Boost only step
      9. Resize the window to less than 400 pixels wide (when the open drawer will overlap content, rather than sitting inline)
      10. Open the drawer
      11. For each of the view modes, toggle the drawer and Confirm that the alias and link icons are not visible behind the drawer (no z-index problems).
      Show
      Please test in Boost (32/master) and clean (all) and with all major browsers Test prerequisites You must have 2 courses You must have the hebrew language pack or other RTL language pack installed. This tests uses a folder resource to test the filemanager icon styles. In order to generate the required (link,alias) icons, some pre-test steps need to be carried out. Folder set up (in English/LTR) In the first course, create a single file resource (any file type that can be accepted is fine). In the second course, create a folder resource Edit the folder resource and add a alias to a file like so: Click 'Add file' On the left pane, select 'Sever files' Find the file you created in the first course. Click it but don't proceed yet. In the dialog, make sure to check the box next to 'Create an alias/shortcut to the file' and then proceed to add the file. Now, add another file from your local filesystem to the folder. Add a subfolder to the folder. You should now have 2 files in the folder (one alias, one real file) and one subfolder. Save the folder now. Now, back in course 1 create a folder resource. Edit the folder resource and add an alias to the real file in course 2 like so: Click 'Add file' On the left pane, select 'Sever files' Find the file you created within the folder in the second course. Click it but don't proceed yet. In the dialog, make sure to check the box next to 'Create an alias/shortcut to the file' and then proceed to add the file. Save the folder. Now, edit the folder in course 2 again (default view): Confirm that : You see 2 files and one subfolder in the folder One file has an alias icon (arrow) in the bottom left corner. The other file has a link icon (chain link) in the bottom right corner. The folder has an edit icon on the bottom right corner. If you don't see the above icons, check again, as we'll need this as the starting point for the test below. Testing views (English/LTR) Edit the folder in course 2. Change the view to 'File details' Confirm that : The alias icon is aligned to the bottom left of its respective file icon. The link icon is aligned to the bottom right of its respective file icon. The edit subfolder icon is aligned to the bottom right of its respective subfolder. Change the view to 'File tree' Confirm that the above three conditions are also true Boost only step Resize the window to less than 400 pixels wide (when the open drawer will overlap content, rather than sitting inline) Open the drawer For each of the view modes, toggle the drawer and Confirm that the alias and link icons are not visible behind the drawer (no z-index problems). Testing views (Hebrew/RTL) Edit the folder in course 2. Change the language to Hebrew or other RTL Ensure view is 'File icons' Confirm that : The alias icon is aligned to the bottom right of its respective file icon and points towards the file icon. The link icon is aligned to the bottom left of its respective file icon. The edit subfolder icon is aligned to the bottom left of its respective subfolder. Change the view to 'File details' Confirm the above three conditions are also true Change the view to 'File tree' Confirm the above three conditions are also true Boost only step Resize the window to less than 400 pixels wide (when the open drawer will overlap content, rather than sitting inline) Open the drawer For each of the view modes, toggle the drawer and Confirm that the alias and link icons are not visible behind the drawer (no z-index problems).
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57074-master

      Description

      Filepicker: Link icon should be on the right side of the File icon, in RTL mode (Theme:Boost)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jaked Jake Dallimore
                Reporter:
                nadavkav Nadav Kavalerchik
                Peer reviewer:
                Simey Lameze
                Integrator:
                Dan Poltawski
                Tester:
                Jun Pataleta
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias, Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/17