Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57084

Day separator in messaging is not pushed back when loading more messages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2.1
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. Create lots of messages between two users.
      2. Load the conversation.
      3. Slowly scroll up to the last visible message and make note of the date separator of the last message.
      4. Scroll more to load previous messages.
      5. The date separator should be pushed up as the previous messages belong to the same date as the separator.
      Test 2
      1. Create lots of messages between two users, alter the values in the DB so they all aren't on the same day.
      2. Load the conversation.
      3. Slowly scroll up to the last visible message and make note of the date separator of the last message.
      4. Scroll more to load previous messages.
      5. If the date separator is the same it should be pushed up.
      6. Continue until the date separator is not pushed up because the date has changed.
      Test 3
      1. On a site containing at least two users - log in as a user and navigate to the messaging page.
      2. Make sure there are no errors in the developer console in the browser when the messaging area has no message.
      3. Send a message to another user.
      4. Log in as the other user in a separate browser
      5. Send messages back and forth between each user, the messaging area should automatically update with the new messages between each user and a date separator should not be added.
      Show
      Test 1 Create lots of messages between two users. Load the conversation. Slowly scroll up to the last visible message and make note of the date separator of the last message. Scroll more to load previous messages. The date separator should be pushed up as the previous messages belong to the same date as the separator. Test 2 Create lots of messages between two users, alter the values in the DB so they all aren't on the same day. Load the conversation. Slowly scroll up to the last visible message and make note of the date separator of the last message. Scroll more to load previous messages. If the date separator is the same it should be pushed up. Continue until the date separator is not pushed up because the date has changed. Test 3 On a site containing at least two users - log in as a user and navigate to the messaging page. Make sure there are no errors in the developer console in the browser when the messaging area has no message. Send a message to another user. Log in as the other user in a separate browser Send messages back and forth between each user, the messaging area should automatically update with the new messages between each user and a date separator should not be added.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57084_master

      Description

      1. Create lots of messages between two users
      2. Load the conversation
      3. Slowly scroll up to the last visible message
        • You should see the date separator of the last message
      4. Scroll more to load previous messages

      Expected

      • The date separator is pushed up as the previous messages belong to the same date as the separator.

      Actual

      • The messages are added above the date separator.

      Note, this didn't happen if I switched conversation, it needs the page to load on the large conversation, or to only have one conversation.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/17