Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57095

Polishing up the notifications screen

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. Please test on both boost and clean theme
      2. Create a course, enrol a student, and add a forum activity and set the subscription mode to forced and read tracking to optional (under the "subscription and tracking" section).
      3. Log in as a student, make sure you've enabled web notifications for forums
        1. Go to notification preferences (notification popover > preferences cog thingo)
        2. Turn on web notifications for forums both online and offline
      4. Log back in as the admin/teacher and create a discussion in the forum
      5. Add a post to the discussion you just created
      6. run cron (from the command line php admin/cli/cron.php)
      7. Log in as the student
      8. You should now have an unread notification about the discussion in the forum
      9. Open the notification popover and click on the "View full notification" link for the notification to see the full notification in the notifications page
      10. Confirm that the notification content no longer has the giant whitespace padding as highlighted in red in
      Show
      Please test on both boost and clean theme Create a course, enrol a student, and add a forum activity and set the subscription mode to forced and read tracking to optional (under the "subscription and tracking" section). Log in as a student, make sure you've enabled web notifications for forums Go to notification preferences (notification popover > preferences cog thingo) Turn on web notifications for forums both online and offline Log back in as the admin/teacher and create a discussion in the forum Add a post to the discussion you just created run cron (from the command line php admin/cli/cron.php) Log in as the student You should now have an unread notification about the discussion in the forum Open the notification popover and click on the "View full notification" link for the notification to see the full notification in the notifications page Confirm that the notification content no longer has the giant whitespace padding as highlighted in red in
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57095-master

      Description

      There is quite a lot of excess whitespace around the notification content.

      Also the navbar links all open in new windows and probably shouldn't.

        Attachments

        1. assign-padding-without-patch.png
          assign-padding-without-patch.png
          24 kB
        2. assign-padding-with-patch.png
          assign-padding-with-patch.png
          23 kB
        3. screenshot-1.png
          screenshot-1.png
          203 kB
        4. screenshot-2.png
          screenshot-2.png
          203 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16