Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57101

Embeded youtube videos do not work correctly in ajax messaging interface

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable both filters "URL to link" and "Media plugin"
        • NONE of the filters must be set to Content and headings, only just Content
      2. Order the "URL to link" filter above the other one
      3. Go to your messages and create a new conversation with someone and send them a message
        • In a separate browser (B) open that conversation and wait for new messages to come
      4. Send a few YouTube videos to that person
      5. Confirm that the video loads in a player when:
        • you sent the message
        • you refresh the page
        • you navigate away and back to this conversation
        • the other sends you a message which is automatically pulled in (no refresh)
        • the message is automatically pulled in B even though there weren't any video visible when the page loaded (because the conversation was almost empty)
      6. Access message/index.php?contactsfirst=1 directly
        • The debug information at the bottom of the page must indicate "Pieces of content filtered: 0"
      7. Search for a contact which you've sent the video to
      8. Load the conversation and confirm that the video appears

      Test 2

      1. Use Clean (simply because the layout does not cause a call to format_text)
      2. Download the attached file test.php to your dirroot.
      3. Go to your Admin > Plugins > Filters and ensure that none of the plugins are enabled on headings
        • Multimedia should be enabled
      4. Access the file test.php
      5. Confirm that (using the data in and at the bottom of the page):
        • The multimedia filter is enabled
        • Pieces of content filtered is 0
      6. Click "Click here!" and confirm that a video loads with a large play button
      7. Go to your Admin > Plugins > Filters and mark the multimedia plugin as "Off but available"
      8. Click "Click here!" again and confirm that the video does not load, only a link
        • The page should not report the multimedia plugin as being enabled.
      9. Go to a course, and enable the "Multimedia filter"
        • Note the course context ID (see bottom of the page)
      10. Access /test.php?contextid=YourCourseContextId
        • Confirm that the page still shows Pieces of content filtered: 0
      11. Click "Click here!" and confirm that a video loads with a large play button
        • The page should report the multimedia plugin as enabled.
      12. Disable the filter in the course and confirm that the video will not load, only a link will be shown
      Show
      Enable both filters "URL to link" and "Media plugin" NONE of the filters must be set to Content and headings , only just Content Order the "URL to link" filter above the other one Go to your messages and create a new conversation with someone and send them a message In a separate browser (B) open that conversation and wait for new messages to come Send a few YouTube videos to that person E.g. https://www.youtube.com/watch?v=4_PsjQgkTM4 Confirm that the video loads in a player when: you sent the message you refresh the page you navigate away and back to this conversation the other sends you a message which is automatically pulled in (no refresh) the message is automatically pulled in B even though there weren't any video visible when the page loaded (because the conversation was almost empty) Access message/index.php?contactsfirst=1 directly The debug information at the bottom of the page must indicate "Pieces of content filtered: 0" Search for a contact which you've sent the video to Load the conversation and confirm that the video appears Test 2 Use Clean (simply because the layout does not cause a call to format_text) Download the attached file test.php to your dirroot . Go to your Admin > Plugins > Filters and ensure that none of the plugins are enabled on headings Multimedia should be enabled Access the file test.php Confirm that (using the data in and at the bottom of the page): The multimedia filter is enabled Pieces of content filtered is 0 Click "Click here!" and confirm that a video loads with a large play button Go to your Admin > Plugins > Filters and mark the multimedia plugin as "Off but available" Click "Click here!" again and confirm that the video does not load, only a link The page should not report the multimedia plugin as being enabled. Go to a course, and enable the "Multimedia filter" Note the course context ID (see bottom of the page) Access /test.php?contextid=YourCourseContextId Confirm that the page still shows Pieces of content filtered: 0 Click "Click here!" and confirm that a video loads with a large play button The page should report the multimedia plugin as enabled. Disable the filter in the course and confirm that the video will not load, only a link will be shown
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57101-master-2nd

      Description

      Follow on from MDL-56938, the styling is not quite right, but also in my testing the video doesn't even load.

      Steps to reproduce:

      1. Enable url to link filter (first) and media plugin filter
      2. Send a youtube link (https://www.youtube.com/watch?v=wop3FMhoLGs) to another user
      3. In the sent messages display, the youtube video does not load

      The same thing happens any time the video is displayed dynmaically with ajax rather than properly loaded with a full page refresh.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16