[MDL-57147] core_cache_testcase::test_static_acceleration fails on some windows - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.3, 3.2
Fix Version/s: 3.1.4
Component/s: Unit tests
Labels:
- ci
- triaged

Testing Instructions:

Hide

Run unit test on windows 32 bit and 64 bit.

Show
Run unit test on windows 32 bit and 64 bit.
Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
https://github.com/rajeshtaneja/moodle.git
Pull Master Branch:
wip-mdl-57147
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...rajeshtaneja:wip-mdl-57147

Description

As spotted by Eloy Lafuente (stronk7) on windows 32 bits, any db, php 7, core_cache_testcase::test_static_acceleration fails, because windows only have 1/100 microtime resolution so a lot of times it does not advance "enough".

https://bugs.php.net/bug.php?id=64633

3.2rc2
1 failure (same)
http://pastebin.com/8HF8MqYL

As per his recommendation, change those assertGreaterThan() by assertGreaterThanOrEqual() and forget (with a comment explaining it).

Attachments

Issue Links

Discovered while testing

MDLQA-10292 CLONE - Run unit test and behat on windows

Passed

Activity

People

Assignee:: Rajesh Taneja

Reporter:: Rajesh Taneja

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: David Monllaó

Tester:: cameron1729

Participants:: cameron1729, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Rajesh Taneja

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 25/Nov/16 5:50 PM

Updated:: 30/Nov/16 10:03 AM

Resolved:: 30/Nov/16 10:03 AM

Fix Release Date:: 9/Jan/17