Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57170

repository_dropbox: Ensure Dropbox Legacy continues to work

    XMLWordPrintable

Details

    • MOODLE_31_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • Hide

      If sitewide SSL is enabled, then configure to Dropbox API v2. Otherwise, this patch is required.

      Show
      If sitewide SSL is enabled, then configure to Dropbox API v2. Otherwise, this patch is required.
    • Easy
    • Hide
      1. Set your site to use HTTP, not HTTPS
      2. Enable and configure the Dropbox repository with Use the deprecated v1 API selected.
      3. Confirm that you can upload files to your private files using the Dropbox repository.
      4. Switch your site to HTTPS and repeat

      v2 test

      1. Continuing from the previous test, change the Dropbox settings to use the OAuth 2 API (recommended) method
      2. Confirm that at this stage you cannot download files to your private files using Dropbox
      3. Add the callback URL (OAuth 2 Redirect URI) to your Dropbox app
      4. Confirm that you can now download files to your private files using the Dropbox repository.
      Show
      Set your site to use HTTP, not HTTPS Enable and configure the Dropbox repository with Use the deprecated v1 API selected. https://docs.moodle.org/31/en/Dropbox_repository https://www.dropbox.com/developers/apps Confirm that there aren't any callback URLs added to your Dropbox app Confirm that you can upload files to your private files using the Dropbox repository. Switch your site to HTTPS and repeat v2 test Continuing from the previous test, change the Dropbox settings to use the OAuth 2 API (recommended) method Confirm that at this stage you cannot download files to your private files using Dropbox Add the callback URL (OAuth 2 Redirect URI) to your Dropbox app https://www.dropbox.com/developers/apps Confirm that you can now download files to your private files using the Dropbox repository.

    Description

      After MDL-52051 was implemented in Moodle 3.1.3, the following error is thrown when trying to access Dropbox in legacy mode.

      error/Error while requesting an oauth token
      Debug info: Error code: Error while requesting an oauth token $a contents:
      Stack trace:

      • line 231 of ./lib/oauthlib.php: moodle_exception thrown
      • line 144 of ./repository/dropbox/classes/legacy.php: call to oauth_helper->request_token()
      • line 541 of ./repository/dropbox/lib.php: call to repository_dropbox_legacy->print_login()
      • line 108 of ./repository/repository_ajax.php: call to repository_dropbox->print_login()

      Attachments

        Issue Links

          is a regression caused by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-52051 Migrate to Dropbox API v2

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              tlock Tim Lock
              tlock Tim Lock
              Frédéric Massart Frédéric Massart
              David Monllaó David Monllaó
              John Okely John Okely
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jan/17