Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57171

Boost: Use Bootstrap classes for the labels in the Status column of the Server checks/Environment pages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as admin
      2. Navigate to Site administration / Server / Environment
      3. Edit php.ini and disable opcache:

        opcache.enable=0
        

      4. Disable the php-zip extension.
        If on ubuntu, open a terminal and key in:

        sudo phpdismod zip
        

      5. Restart the web server.
      6. Back on the browser, and refresh the Environment page.
      7. Check the "Report" column and check the entries for "php_extension - zip" and "php_setting - opcache.enable".
        • Confirm that the feedback messages (the ones highlighted) are below the "must be installed and enabled"/"PHP setting should be changed" report texts.
        • Confirm that the text highlights look similar. (They might have different background colours, but their appearance should be the same).
      8. Check the "Status" column.
        • Confirm that the status labels look similar to the Bootstrap label classes. (They might have different background colours, but their appearance should be the same).
      9. Switch to Clean theme.
      10. Check the "Report" column and check the entries for "php_extension - zip" and "php_setting - opcache.enable".
        • Confirm that the feedback messages (the ones highlighted) are below the "must be installed and enabled"/"PHP setting should be changed" report texts.
        • Confirm that the text highlights look similar. (They might have different background colours, but their appearance should be the same).
      11. Check the "Status" column.
        • Confirm that the status labels look similar to the Bootstrap label classes. (They might have different background colours, but their appearance should be the same).
      Feedback, Bypass and Restrict strings
      1. Hack admin/renderer.php and add the following code right before the "$feedbacktext" declaration (before here).

        if (empty($environment_result->getFeedbackStr())) {
            $environment_result->setFeedbackStr('accessdenied');
        }
        $environment_result->setBypassStr('accessdenied');
        $environment_result->setRestrictStr('accessdenied');
        

      2. Refresh the Environment page.
        • Confirm that the Bypass and Restrict strings have similar appearance consistent with the Feedback string. (They might have different background and font colours, but their appearance should be the same).
      3. Switch to Boost theme.
      4. Navigate to the Environment page.
        • Confirm that the Bypass and Restrict strings have similar appearance consistent with the Feedback string. (They might have different background and font colours, but their appearance should be the same).
      Show
      Login as admin Navigate to Site administration / Server / Environment Edit php.ini and disable opcache: opcache.enable=0 Disable the php-zip extension. If on ubuntu, open a terminal and key in: sudo phpdismod zip Restart the web server. Back on the browser, and refresh the Environment page. Check the " Report " column and check the entries for "php_extension - zip" and "php_setting - opcache.enable". Confirm that the feedback messages (the ones highlighted) are below the " must be installed and enabled "/" PHP setting should be changed " report texts. Confirm that the text highlights look similar. (They might have different background colours, but their appearance should be the same). Check the " Status " column. Confirm that the status labels look similar to the Bootstrap label classes. (They might have different background colours, but their appearance should be the same). Switch to Clean theme. Check the " Report " column and check the entries for "php_extension - zip" and "php_setting - opcache.enable". Confirm that the feedback messages (the ones highlighted) are below the " must be installed and enabled "/" PHP setting should be changed " report texts. Confirm that the text highlights look similar. (They might have different background colours, but their appearance should be the same). Check the " Status " column. Confirm that the status labels look similar to the Bootstrap label classes. (They might have different background colours, but their appearance should be the same). Feedback, Bypass and Restrict strings Hack admin/renderer.php and add the following code right before the " $feedbacktext " declaration (before here ). if ( empty ( $environment_result ->getFeedbackStr())) { $environment_result ->setFeedbackStr( 'accessdenied' ); } $environment_result ->setBypassStr( 'accessdenied' ); $environment_result ->setRestrictStr( 'accessdenied' ); Refresh the Environment page. Confirm that the Bypass and Restrict strings have similar appearance consistent with the Feedback string. (They might have different background and font colours, but their appearance should be the same). Switch to Boost theme. Navigate to the Environment page. Confirm that the Bypass and Restrict strings have similar appearance consistent with the Feedback string. (They might have different background and font colours, but their appearance should be the same).
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57171-master-2

      Description

      The labels for the Status column in the "Server checks" page and "Environment" admin page can be improved to use the Bootstrap classes (e.g. "label label-success", "label label-warning". etc).

      See comparison with some labels with the "label label-success" class applied:

        Attachments

        1. fixed-boost.png
          fixed-boost.png
          59 kB
        2. fixed-clean.png
          fixed-clean.png
          59 kB
        3. screenshot-1.png
          screenshot-1.png
          48 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/17