Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.1
-
Component/s: Navigation, Themes
-
Testing Instructions:
-
Affected Branches:MOODLE_31_STABLE
-
Fixed Branches:MOODLE_31_STABLE, MOODLE_32_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-57182-master -
Pull Master Diff URL:
Description
I noticed this when reviewing MDL-56955. When $CFG->displayloginfailures is set to true (in config.php), there should be a notice in both the header (nav) and the footer. It seems MDL-45893 introduced a regression in this setting, by making 2 calls to user_count_login_failures with the reset flag set to default=true. The first call (header/nav) works fine, however, the second (which dictates the rendering of the footer notice) returns 0, meaning the notice never gets shown.