Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57197

Bump all versions, requires and dependencies near 3.2 release in master

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: General, Installation
    • Labels:
    • Testing Instructions:
      Hide

      A) Definition: "VERSION" == 2016120500 (planned release version/date)
      B) Definition: "REQUIRE" == 2016112900 (current Beta/RCX)

      1) TEST: Visually verify that all the changes in the patch point to the correct "VERSION" versions and all the requires and dependencies point to the correct "REQUIRE" and nothing else is changed. Note main version.php file must be >= "REQUIRE".

      2) Upgrade from any previous 2.7.x - 3.1dev version.

      • TEST: In the plugins screen ALL the plugins are showing "to upgrade".
      • TEST: All the target versions show "VERSION" and all the dependencies show the "REQUIRE" version along the whole page.
      • TEST: Run upgrade. Ends without error.

      3) Verify that there isn't any plugin version.php file missing the "VERSION". Something like this should do the trick (ignore main version.php, that's ok, will be updated on release day):

      find . -name version.php | grep -v fixtures | xargs grep -L VERSION
      

      4) TEST: To integrators, verify the "Check version.php files (master)" job in the integration server ends without error, that everything points to "VERSION" / "REQUIRE" versions and that the report does not include any "ERROR" looking to the generated "versions_check_set.txt" file in the workspace. Note some "WARN" can exist. But that's not relevant for this issue.

      Show
      A) Definition: "VERSION" == 2016120500 (planned release version/date) B) Definition: "REQUIRE" == 2016112900 (current Beta/RCX) 1) TEST: Visually verify that all the changes in the patch point to the correct "VERSION" versions and all the requires and dependencies point to the correct "REQUIRE" and nothing else is changed. Note main version.php file must be >= "REQUIRE". 2) Upgrade from any previous 2.7.x - 3.1dev version. TEST: In the plugins screen ALL the plugins are showing "to upgrade". TEST: All the target versions show "VERSION" and all the dependencies show the "REQUIRE" version along the whole page. TEST: Run upgrade. Ends without error. 3) Verify that there isn't any plugin version.php file missing the "VERSION". Something like this should do the trick (ignore main version.php, that's ok, will be updated on release day): find . -name version.php | grep -v fixtures | xargs grep -L VERSION 4) TEST: To integrators, verify the "Check version.php files (master)" job in the integration server ends without error, that everything points to "VERSION" / "REQUIRE" versions and that the report does not include any "ERROR" looking to the generated "versions_check_set.txt" file in the workspace. Note some "WARN" can exist. But that's not relevant for this issue.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This task corresponds to point #3 of:

      https://docs.moodle.org/dev/Release_process#1_week_prior

      And it's achieved in a semi-automated way with the "versions_check_set.sh" script available @ https://github.com/moodlehq/moodle-local_ci/blob/master/versions_check_set/versions_check_set.sh

      1) In a git, working, master site with the ci local plugin installed.

      2) Define and export all the env variables required by the script.

      • $WORKSPACE: Path to the directory where test reults will be sent (/tmp)
      • $phpcmd: Path to the PHP CLI executable (/usr/bin/php)
      • $gitdir: Directory containing git repo (the dirroot of the git, working site)
      • $setversion: 10digits (YYYYMMDD00) to set all versions to. Empty = not set. Since Moodle 2.7 it has been agreed to perform the bump to the planned release version. For easier automated checks later in stable-land.
      • $setrequires: 10digits (YYYYMMDD00) to set all requires to. Empty = default to $setversion. Since Moodle 2.7 it has been agreed to perform the requires bump to current master version (usually a RC one).

      3) Run it. With errors, they will be reported and fixing will be necessary. (look for ERROR in the $WORKSPACE/versions_check_set.txt file and/or check exit status of the script)

      4) Without errors, all the versions, requires and dependencies will be bumped.

      5) Commit

      6) Note that the main version file is NOT updated at all. One extra commit bumping it may be necessary (to anything >= requires version).

      7) Run the checker again to verify that there are no errors and no more changes are performed.

      Note the checker is also run periodically by the ci server and also as part of the "remote_branch_checker", so normally all the version.php files should be under control.

      (This issue will be cloned for each major release).

      Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16