[MDL-57198] Button to restrict access to chosen group is missing classes to be displayed correctly in Boost-Theme - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.2
Fix Version/s: 3.2.1
Component/s: Course, Themes
Labels:
- ci
- triaged

Testing Instructions:
Hide

Ensure conditional access is enabled

Go to a course

Ensure Groups/Groupings are present

Enable edit mode

Click on link to add ressource or activity

Choose activity module supporting groups/groupings (e.g. assign)

Open section "Common module settings"

Ensure button "Add group/grouping access restriction" is properly formatted
Show
Ensure conditional access is enabled Go to a course Ensure Groups/Groupings are present Enable edit mode Click on link to add ressource or activity Choose activity module supporting groups/groupings (e.g. assign) Open section "Common module settings" Ensure button "Add group/grouping access restriction" is properly formatted
URL:
https://qa.moodle.net/course/modedit.php?add=assign&type=&course=56&section=0&return=0&sr=0
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/phager-at/moodle.git
Pull Master Branch:
~~MDL-57198~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...phager-at:MDL-57198

Description

When you open the settings page of an activity-module using groups/groupings (e.g. mod_assign) and having restricted access enabled a button is displayed to restrict access to current chosen group. This gets handled in moodleform_mod::standard_coursemodule_elements(). The button-HTML is created without the classes "btn btn-primary" which makes it appear completely unformatted.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

afterpatch.png
39 kB
06/Dec/16 10:35 PM
afterpatch-secondary.PNG
22 kB
06/Dec/16 11:18 PM
MDL-57198.PNG
18 kB
30/Nov/16 9:13 AM

Activity

People

Assignee:

Philipp Hager

Reporter:

Philipp Hager

Peer reviewer:

Simey Lameze

Integrator:

Dan Poltawski

Tester:

Jake Dallimore

Participants:

CiBoT, Dan Poltawski, Jake Dallimore, Marina Glancy, Philipp Hager, Simey Lameze

Component watchers:

Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

30/Nov/16 8:55 AM

Updated:

16/Dec/16 1:38 AM

Resolved:

16/Dec/16 1:38 AM

Fix Release Date:

9/Jan/17