Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57207

Redundant call to .popover() in LTI's tool_configure_controller

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.2
    • 3.2
    • LTI provider
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-57207-master
    • Hide
      1. As admin, browse to "Site administration" > "Plugins" > "Activity modules" > "External tool" > "Manage tools"
      2. Enter something like "http://example.com/tool.xml" (just has to be a URL ending in .xml) in the "Tool URL..." field
      3. Press "Add"
      4. Verify that the help popovers on the "Consumer key" and "Shared secret" fields work as expected
      Show
      As admin, browse to "Site administration" > "Plugins" > "Activity modules" > "External tool" > "Manage tools" Enter something like "http://example.com/tool.xml" (just has to be a URL ending in .xml) in the "Tool URL..." field Press "Add" Verify that the help popovers on the "Consumer key" and "Shared secret" fields work as expected

    Description

      Since MDL-56784 was integrated. It's no longer necessary to call .popover() to initialise popovers added to the DOM after page load. In LTI we have:

      mod/lti/amd/src/tool_configure_controller.js:

          var screenReaderAnnounce = function(element) {
              var children = element.children().detach();
              children.appendTo(element);
              $('[data-toggle="popover"]').popover();
          };
      

      The $('[data-toggle="popover"]').popover(); is now redundant.

      Attachments

        Issue Links

          Activity

            People

              cameron1729 cameron1729
              cameron1729 cameron1729
              Mark Nelson Mark Nelson
              Dan Poltawski Dan Poltawski
              Jake Dallimore Jake Dallimore
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.