Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57220

radio buttons in mform are badly aligned

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Forms Library, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Go to add a badge form and check the alignment and display of the fields at the bottom.

      The radio buttons be lined up with the rest of the form elements (on the left).

      The date selector should have bootstrap styles and be displayed on a single line.

      The 3 sets of options will have too little spacing between them - this is because they are constructed using <br> tags to split the rows - they should be 3 separate form groups instead.

      Show
      Go to add a badge form and check the alignment and display of the fields at the bottom. The radio buttons be lined up with the rest of the form elements (on the left). The date selector should have bootstrap styles and be displayed on a single line. The 3 sets of options will have too little spacing between them - this is because they are constructed using <br> tags to split the rows - they should be 3 separate form groups instead.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57220-master

      Description

      Copy the attached file in your head root.
      Navigate it and look at the left alignment of mform elements. (If you have no time and trust me, a screenshot is attached too.)
      IMO line 232 of head/theme/boost/scss/bootstrap/_forms.scss
      should be changed from
      padding-left: 1.25rem;
      to
      padding-right: 1.25rem;

        Attachments

        1. mform_code.php
          7 kB
          Daniele Cordella
        2. Screenshot 2016-11-30 08.15.07.png
          40 kB
          Daniele Cordella
        3. wrong_aligns.png
          65 kB
          Eloy Lafuente (stronk7)

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            daniss Daniele Cordella
            Peer reviewer:
            Simey Lameze
            Integrator:
            Dan Poltawski
            Tester:
            John Okely
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16