Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57222

Marking workflow and grading do not save when Assignment hidden

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Create a course with a student.
      2. Create an assignment with marking workflow enabled.
      3. Mark the student but leave the 'Marking workflow state' to anything but 'Released'.
      4. Uncheck 'Notify students'.
      5. Save the form and confirm you get a message saying it saved successfully.
      6. Check 'Notify students'.
      7. Save the form and confirm you get an error message saying you can not notify students without changing the 'Marking workflow state'.
      8. Set the 'Marking workflow state' to 'Released'.
      9. Save the form and confirm you get a message saying it saved successfully.
      Test 2
      1. Create a course with a student.
      2. Create an assignment with marking workflow enabled.
      3. Hide the assignment.
      4. Mark the student but leave the 'Marking workflow state' to anything but 'Released'.
      5. Uncheck 'Notify students'.
      6. Save the form and confirm you get a message saying it saved successfully.
      7. Check 'Notify students'.
      8. Save the form and confirm you get an error message saying you can not notify students without changing the 'Marking workflow state'.
      9. Set the 'Marking workflow state' to 'Released'.
      10. Save the form and confirm you get a message saying it saved successfully.
      Test 3
      1. Create a course with a student.
      2. Create an assignment with marking workflow enabled.
      3. Go to grade the student but change the 'action' URL param to 'grade'.
      4. Mark the student but leave the 'Marking workflow state' to anything but 'Released'.
      5. Confirm the 'Notify students' checkbox is disabled.
      6. Save the form and confirm you get a message saying it saved successfully.
      7. Go to grade the student but change the 'action' URL param to 'grade'.
      8. Set the 'Marking workflow state' to 'Released'.
      9. Confirm the 'Notify students' checkbox is enabled and set it to 'Yes'.
      10. Save the form and confirm you get a message saying it saved successfully.
      Test 4
      1. Create a course with a student.
      2. Create an assignment with marking workflow enabled.
      3. Hide the assignment.
      4. Go to grade the student but change the 'action' URL param to 'grade'.
      5. Mark the student but leave the 'Marking workflow state' to anything.
      6. Confirm the 'Notify students' field simply says 'No' next to it.
      7. Save the form and confirm you get a message saying it saved successfully.
      Show
      Test 1 Create a course with a student. Create an assignment with marking workflow enabled. Mark the student but leave the 'Marking workflow state' to anything but 'Released'. Uncheck 'Notify students'. Save the form and confirm you get a message saying it saved successfully. Check 'Notify students'. Save the form and confirm you get an error message saying you can not notify students without changing the 'Marking workflow state'. Set the 'Marking workflow state' to 'Released'. Save the form and confirm you get a message saying it saved successfully. Test 2 Create a course with a student. Create an assignment with marking workflow enabled. Hide the assignment. Mark the student but leave the 'Marking workflow state' to anything but 'Released'. Uncheck 'Notify students'. Save the form and confirm you get a message saying it saved successfully. Check 'Notify students'. Save the form and confirm you get an error message saying you can not notify students without changing the 'Marking workflow state'. Set the 'Marking workflow state' to 'Released'. Save the form and confirm you get a message saying it saved successfully. Test 3 Create a course with a student. Create an assignment with marking workflow enabled. Go to grade the student but change the 'action' URL param to 'grade'. Mark the student but leave the 'Marking workflow state' to anything but 'Released'. Confirm the 'Notify students' checkbox is disabled. Save the form and confirm you get a message saying it saved successfully. Go to grade the student but change the 'action' URL param to 'grade'. Set the 'Marking workflow state' to 'Released'. Confirm the 'Notify students' checkbox is enabled and set it to 'Yes'. Save the form and confirm you get a message saying it saved successfully. Test 4 Create a course with a student. Create an assignment with marking workflow enabled. Hide the assignment. Go to grade the student but change the 'action' URL param to 'grade'. Mark the student but leave the 'Marking workflow state' to anything. Confirm the 'Notify students' field simply says 'No' next to it. Save the form and confirm you get a message saying it saved successfully.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull 3.1 Branch:
      MDL-57222_m31
    • Pull Master Branch:
      MDL-57222_master
    • Sprint:
      3.3 on-sync

      Description

      To reproduce...

      1. Create a course with a teacher and some students
      2. Create an assignment, accept defaults except...
      3. Enable marking workflow
      4. Set visibility to hidden.
      5. Display the assignment and attempt to mark one of the students (it doesn't matter if they've actually submitted something or not). Select a grade and change the marking workflow to 'Marking completed'. Press Save

      It doesn't save. No 'saved' dialogue appears and the grade + workflow status do not update.

      If you un-hide the activity it all works fine again. I can't think of any reason why one should not be able to grade a hidden assignment.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/17