Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57232

After upgrade to 3.2, some blocks do not disappear when they should, and some do disappear when they should not

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide
      1. New install - boost. Verify nav and settings blocks don't show.
      2. Switch to clean - verify nav and settings blocks do show.
      3. Switch back to boost - verify nav and settings blocks do not show
      4. Switch to clean - attempt a quiz set to show in a secure window
      5. Switch to boost - verify nav and settings blocks do not show
      6. Manually add the settings block to a course in boost
      7. Switch to clean - verify you only see one settings block
      8. Switch back to boost - verify you only see the settings block in the course it was added to.
      9. Go to admin page manage blocks and protect some blocks and un-protect some blocks
      10. Verify the locked icon changes as blocks are protected / unprotected.
      11. Verify protected blocks cannot be added or deleted manually - and are not automatically added unless they are required by the theme.
      1. From a 3.1 site, protect some blocks via admin page - then upgrade to 3.2 with this commit.
      2. Verify any protected blocks were not auto-created and the list of protected blocks did not change at all.
      Show
      New install - boost. Verify nav and settings blocks don't show. Switch to clean - verify nav and settings blocks do show. Switch back to boost - verify nav and settings blocks do not show Switch to clean - attempt a quiz set to show in a secure window Switch to boost - verify nav and settings blocks do not show Manually add the settings block to a course in boost Switch to clean - verify you only see one settings block Switch back to boost - verify you only see the settings block in the course it was added to. Go to admin page manage blocks and protect some blocks and un-protect some blocks Verify the locked icon changes as blocks are protected / unprotected. Verify protected blocks cannot be added or deleted manually - and are not automatically added unless they are required by the theme. From a 3.1 site, protect some blocks via admin page - then upgrade to 3.2 with this commit. Verify any protected blocks were not auto-created and the list of protected blocks did not change at all.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57232-master

      Description

      While testing upgrade of moodle.org, we are experiencing troubles with the custom Partners block appearing multiple times (discussed in MDL-56902). I was trying to debug and reproduce the issue and hit more problems.

      Steps to reproduce

      1. Start with a fresh new 3.1 site with two courses A and B
      2. Add a new HTML block to the front page and another one to a course A
      3. Add a new block of a different type (such as Logged in user) to the same two places.
      4. On the Manage blocks admin page, protect the HTML blocks from deletion (the lock icon),
        like Navigation and Administration blocks are.
      5. Upgrade the site to 3.2
      6. Problem 1: Note that the HTML blocks are not displayed now at all. The Manage blocks admin page still displays the instances exist.
      7. Switch the site theme to Boost
      8. Problem 2: The blocks Navigation and Administration are still displayed, even if they should not.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16