Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57240

For an overdue quiz attempt, the summary page has links that just redirect back to the same page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test that the fix worked

      1. Create a quiz with settings:
        • Time limit: 5 mins
        • When time expires: There is a grace period when open attempts can be submitted, but no more questions answered
        • Grade period: 1 day
      2. Add at least one question to the quiz (true-false is quickest).
      3. As a student, start an attempt at the quiz.
      4. Click 'Finish attempt...' button to get to the attempt summary page.
      5. Verify that on the summary page, there is no 'Finish attempt...' link in the navigation block.
      6. Verify that the question number '1' in the table is a link, and clicking it takes you back to that question in the quiz attempt.
      7. Click 'Finish attempt...' button to get to the attempte summary page.
      8. Verify that in the Quiz navigation block, you can click the button for Q1 to get back to that question in the attempt.
      9. Do not submit, anything. Just navigate away from quiz (e.g. go to the course page.)
      10. Wait for the five-minute time limit to expire.
      11. Go back to the quiz, and click Continue attempt.
      12. Verify you are taken to the attempt summary page, with a message saying that the quiz is now overdue. (This has not changed due to this issue.)
      13. Verify that in the table, each question number is not a link.
      14. Verify that in the Quiz navigation block, the question numbers are not links.
      Show
      Test that the fix worked Create a quiz with settings: Time limit: 5 mins When time expires: There is a grace period when open attempts can be submitted, but no more questions answered Grade period: 1 day Add at least one question to the quiz (true-false is quickest). As a student, start an attempt at the quiz. Click 'Finish attempt...' button to get to the attempt summary page. Verify that on the summary page, there is no 'Finish attempt...' link in the navigation block. Verify that the question number '1' in the table is a link, and clicking it takes you back to that question in the quiz attempt. Click 'Finish attempt...' button to get to the attempte summary page. Verify that in the Quiz navigation block, you can click the button for Q1 to get back to that question in the attempt. Do not submit, anything. Just navigate away from quiz (e.g. go to the course page.) Wait for the five-minute time limit to expire. Go back to the quiz, and click Continue attempt. Verify you are taken to the attempt summary page, with a message saying that the quiz is now overdue. (This has not changed due to this issue.) Verify that in the table, each question number is not a link. Verify that in the Quiz navigation block, the question numbers are not links.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Steps to reproduce

      1. You need a quiz set to When time expires: There is a grace period when open attempts can be submitted, but no more questions answered. Set the Grade period to 1 day, and the Time limit to 1 minute.
      2. Add at least on question to the quiz.
      3. As a student, start an attempt at the quiz. Do not submit, anything. Just navigate away from quiz (e.g. go to the course page.)
      4. Wait for time to expire.
      5. Go back to the quiz, and click Continue attempt.

      This will take you to the attempt summary page, with a message saying that the quiz is now overdue.

      Actual result:

      • In the table that lists the status of each question, the question number is a link. When you click it, you just get redirected back to the same page.
      • In the Quiz navigation block, the question numbers are links. Again, they just redirect you back to the same page.

      Expected results: Those elements should be present on-screen, but in this case ($attemptobj->get_state() == quiz_attempt::OVERDUE) they should not be links.

        Attachments

          Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-68499 Quiz / Behat: there are not tests of the handling of overdue attempts

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Sam Marshall Sam Marshall
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jul/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h