Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57259

Using fragments triggers debugging message regarding missing set_url() call

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Make sure debug logging is enabled
      2. Log in as admin
      3. Make sure the "email" message output is enabled
        • Site administration > plugins > message outputs > manage message outputs
      4. Go to the notifications preferences page (notification popover > cog icon)
      5. Click the "email" cog link at the top of the table to open the processor settings in a modal (this is loaded using a fragment)
      6. View your apache error log /var/log/apache2/error.log (or where ever you've got your logs going) and confirm that the debug message does not appear
      Show
      Make sure debug logging is enabled Log in as admin Make sure the "email" message output is enabled Site administration > plugins > message outputs > manage message outputs Go to the notifications preferences page (notification popover > cog icon) Click the "email" cog link at the top of the table to open the processor settings in a modal (this is loaded using a fragment) View your apache error log /var/log/apache2/error.log (or where ever you've got your logs going) and confirm that the debug message does not appear
    • Workaround:
      Hide

      none

      Show
      none
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-57259-master

      Description

      When grading an an assignment with developer debugging on the following stack trace is in the php.log file:

      [02-Dec-2016 13:30:06 Europe/London] Debugging: This page did not call $PAGE->set_url(...). Using https://moodle31.chloe/lib/ajax/service.php?sesskey=IpFY45jPlh in 
       
      * line 565 of \lib\pagelib.php: call to debugging()
      * line 773 of \lib\pagelib.php: call to moodle_page->magic_get_url()
      * line 3787 of \lib\navigationlib.php: call to moodle_page->__get()
      * line 3518 of \lib\navigationlib.php: call to settings_navigation->load_course_settings()
      * line 724 of \lib\pagelib.php: call to settings_navigation->initialise()
      * line 773 of \lib\pagelib.php: call to moodle_page->magic_get_settingsnav()
      * line 136 of \blocks\settings\block_settings.php: call to moodle_page->__get()
      * line 288 of \blocks\moodleblock.class.php: call to block_settings->get_content()
      * line 230 of \blocks\moodleblock.class.php: call to block_base->formatted_contents()
      * line 976 of \lib\blocklib.php: call to block_base->get_content_for_output()
      * line 1028 of \lib\blocklib.php: call to block_manager->create_block_contents()
      * line 476 of \lib\outputrenderers.php: call to block_manager->ensure_content_created()
      * line 39 of \theme\bootstrapbase\renderers\core_renderer.php: call to core_renderer->standard_head_html()
      * line 52 of \theme\clean\layout\columns3.php: call to theme_bootstrapbase_core_renderer->standard_head_html()
      * line 1028 of \lib\outputrenderers.php: call to include()
      * line 958 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
      * line ? of unknownfile: call to core_renderer->header()
      * line 1827 of \lib\setuplib.php: call to call_user_func_array()
      * line 325 of \lib\external\externallib.php: call to bootstrap_renderer->__call()
      * line 325 of \lib\external\externallib.php: call to bootstrap_renderer->header()
      * line ? of unknownfile: call to core_external::get_fragment()
      * line 229 of \lib\externallib.php: call to call_user_func_array()
      * line 64 of \lib\ajax\service.php: call to external_api::call_external_function()
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Sep/17