Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57274

Moodle 3.2 notices during installation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.2 regressions
    • Fix Version/s: 3.2.2
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide

      Run the following two installation tests on master and 32:

      Installation - Web

      1. Clone a new instance, ready for installation.
      2. Begin web installation, and on the first step, select another language (en_us for example).
      3. Proceed past the 'Paths' step to the DB engine selection step.
      4. Confirm that you don't see any curlsecurity notices on the screen.

      Installation - CLI

      1. Clone a new instance, ready for installation.
      2. Begin cli installation, and on the first step, select another language (en_us for example).
      3. Proceed until you are asked to select the DB engine.
      4. Confirm that you don't see any curlsecurity notices on the screen prior to the current step.

      Now, perform the following tests only on 31 (Where we won't have existing $CFG->curlsecurityxxx settings during upgrade):

      Upgrade 31 to 32 - Web

      1. Create and install a new instance of 31
      2. Install the language pack 'en_us'.
      3. Set this as your preferred language in the page navbar.
      4. Checkout the integration branch for 32
      5. Now, hit the notifications page
      6. Proceed to the 'Plugins check' section of the upgrade.
      7. Click the 'Check for available updates' button at the top of the page and Confirm that you don't see any 'undefined property stdClass:curlsecurityxxx' notices.
      8. Proceed with the upgrade and Confirm that you don't see any 'undefined property stdClass:curlsecurityxxx' notices.
      9. Check the new settings page after upgrade and Confirm that you see the curl settings and that they are empty.

      Upgrade 31 to 32 - CLI

      1. Create and install a new instance of 31
      2. Install the language pack 'en_us'.
      3. Checkout the integration branch for 32
      4. Now, run the cli upgrade with the '--lang=en_us' flag
      5. Proceed with the upgrade and confirm that you don't see any 'undefined property stdClass:curlsecurityxxx' notices.
      Show
      Run the following two installation tests on master and 32: Installation - Web Clone a new instance, ready for installation. Begin web installation, and on the first step, select another language (en_us for example). Proceed past the 'Paths' step to the DB engine selection step. Confirm that you don't see any curlsecurity notices on the screen. Installation - CLI Clone a new instance, ready for installation. Begin cli installation, and on the first step, select another language (en_us for example). Proceed until you are asked to select the DB engine. Confirm that you don't see any curlsecurity notices on the screen prior to the current step. Now, perform the following tests only on 31 (Where we won't have existing $CFG->curlsecurityxxx settings during upgrade): Upgrade 31 to 32 - Web Create and install a new instance of 31 Install the language pack 'en_us'. Set this as your preferred language in the page navbar. Checkout the integration branch for 32 Now, hit the notifications page Proceed to the 'Plugins check' section of the upgrade. Click the 'Check for available updates' button at the top of the page and Confirm that you don't see any 'undefined property stdClass:curlsecurityxxx' notices. Proceed with the upgrade and Confirm that you don't see any 'undefined property stdClass:curlsecurityxxx' notices. Check the new settings page after upgrade and Confirm that you see the curl settings and that they are empty. Upgrade 31 to 32 - CLI Create and install a new instance of 31 Install the language pack 'en_us'. Checkout the integration branch for 32 Now, run the cli upgrade with the '--lang=en_us' flag Proceed with the upgrade and confirm that you don't see any 'undefined property stdClass:curlsecurityxxx' notices.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57274-master

      Description

      Moodle 3.2 installation shows following notices on the screen of database engine selection:

      Notice: Undefined property: stdClass::$curlsecurityallowedport in /var/www/moodle32/moodle/lib/classes/files/curl_security_helper.php on line 238

      Notice: Undefined property: stdClass::$curlsecurityblockedhosts in /var/www/moodle32/moodle/lib/classes/files/curl_security_helper.php on line 250

      Notice: Undefined property: stdClass::$curlsecurityallowedport in /var/www/moodle32/moodle/lib/classes/files/curl_security_helper.php on line 238

      Notice: Undefined property: stdClass::$curlsecurityblockedhosts in /var/www/moodle32/moodle/lib/classes/files/curl_security_helper.php on line 250

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              evsoldatkin Evgeny Soldatkin
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Ankit Agarwal Ankit Agarwal
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              7 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Mar/17