Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57316

If filter_mediaplugins is disabled, video.js is not working in resources

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.2.1
    • Fix Version/s: 3.2.2
    • Component/s: Filters, Media
    • Labels:
    • Testing Instructions:
      Hide

      Test 1

      1. Disable filter_mediaplugins
      2. Make sure video.js is your topmost media plugin
      3. Create a file resource and upload a video to it
      4. Ensure video.js works (should see the rectangular play button at first with no video controls - don't just assume any video player means it's working as it might be HTML5)
      5. Create a url resource set to the url of a video
      6. Ensure video.js works
      7. Create a lesson, set the linked media file to a video (click show more)
      8. Add a content page with any content in
      9. Press Preview
      10. Ensure video.js works
      11. Go to Site administration > PluginsText editors > Manage editors. Move tinymce to the top
      12. Create a page in the course
      13. Use the tinymce media plugin to embed media to the page content
      14. Press preview
      15. Ensure video.js works
      16. Go to Site administration > PluginsText editors > Manage editors. Move tinymce back where it was

      Test 2

      Please note, video scrolling will not work perfectly. This is pre-existing: MDL-57109

      1. Enable both filters "URL to link" and "Media plugin"
        • NONE of the filters must be set to Content and headings, only just Content
      2. Order the "URL to link" filter above the other one
      3. Go to your messages and create a new conversation with someone and send them a message
        • In a separate browser (B) open that conversation and wait for new messages to come
      4. Send a few YouTube videos to that person
      5. Confirm that the video loads in a player when:
        • you sent the message
        • you refresh the page
        • you navigate away and back to this conversation
        • the other sends you a message which is automatically pulled in (no refresh)
        • the message is automatically pulled in B even though there weren't any video visible when the page loaded (because the conversation was almost empty)
      6. Access message/index.php?contactsfirst=1 directly
        • The debug information at the bottom of the page must indicate "Pieces of content filtered: 0"
      7. Search for a contact which you've sent the video to
      8. Load the conversation and confirm that the video appears

      Test 3

      (from MDL-57101)

      1. Use Clean (simply because the layout does not cause a call to format_text)
      2. Download the attached file test.php to your dirroot.
      3. Go to your Admin > Plugins > Filters and ensure that none of the plugins are enabled on headings
        • Multimedia should be enabled
      4. Access the file test.php
      5. Confirm that (using the data in and at the bottom of the page):
        • The multimedia filter is enabled
        • Pieces of content filtered is 0
      6. Click "Click here!" and confirm that a video loads with a large play button
      7. Go to your Admin > Plugins > Filters and mark the multimedia plugin as "Off but available"
      8. Click "Click here!" again and confirm that the video does not load, only a link
        • The page should not report the multimedia plugin as being enabled.
      9. Go to a course, and enable the "Multimedia filter"
        • Note the course context ID (see bottom of the page)
      10. Access /test.php?contextid=YourCourseContextId
        • Confirm that the page still shows Pieces of content filtered: 0
      11. Click "Click here!" and confirm that a video loads with a large play button
        • The page should report the multimedia plugin as enabled.
      12. Disable the filter in the course and confirm that the video will not load, only a link will be shown
      Show
      Test 1 Disable filter_mediaplugins Make sure video.js is your topmost media plugin Create a file resource and upload a video to it Ensure video.js works (should see the rectangular play button at first with no video controls - don't just assume any video player means it's working as it might be HTML5) Create a url resource set to the url of a video Ensure video.js works Create a lesson, set the linked media file to a video (click show more) Add a content page with any content in Press Preview Ensure video.js works Go to Site administration > PluginsText editors > Manage editors. Move tinymce to the top Create a page in the course Use the tinymce media plugin to embed media to the page content Press preview Ensure video.js works Go to Site administration > PluginsText editors > Manage editors. Move tinymce back where it was Test 2 Please note, video scrolling will not work perfectly. This is pre-existing: MDL-57109 Enable both filters "URL to link" and "Media plugin" NONE of the filters must be set to Content and headings , only just Content Order the "URL to link" filter above the other one Go to your messages and create a new conversation with someone and send them a message In a separate browser (B) open that conversation and wait for new messages to come Send a few YouTube videos to that person E.g. https://www.youtube.com/watch?v=4_PsjQgkTM4 Confirm that the video loads in a player when: you sent the message you refresh the page you navigate away and back to this conversation the other sends you a message which is automatically pulled in (no refresh) the message is automatically pulled in B even though there weren't any video visible when the page loaded (because the conversation was almost empty) Access message/index.php?contactsfirst=1 directly The debug information at the bottom of the page must indicate "Pieces of content filtered: 0" Search for a contact which you've sent the video to Load the conversation and confirm that the video appears Test 3 (from MDL-57101 ) Use Clean (simply because the layout does not cause a call to format_text) Download the attached file test.php to your dirroot . Go to your Admin > Plugins > Filters and ensure that none of the plugins are enabled on headings Multimedia should be enabled Access the file test.php Confirm that (using the data in and at the bottom of the page): The multimedia filter is enabled Pieces of content filtered is 0 Click "Click here!" and confirm that a video loads with a large play button Go to your Admin > Plugins > Filters and mark the multimedia plugin as "Off but available" Click "Click here!" again and confirm that the video does not load, only a link The page should not report the multimedia plugin as being enabled. Go to a course, and enable the "Multimedia filter" Note the course context ID (see bottom of the page) Access /test.php?contextid=YourCourseContextId Confirm that the page still shows Pieces of content filtered: 0 Click "Click here!" and confirm that a video loads with a large play button The page should report the multimedia plugin as enabled. Disable the filter in the course and confirm that the video will not load, only a link will be shown
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-MDL-57316-master
    • Sprint:
      3.3 sprint 2

      Description

      1. Disable filter_mediaplugins
      2. Create a file or url resource with a video in it
      3. Video.js will not load javascript

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Mar/17