[MDL-57319] Time limit needs raising for scss compilation - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.2, 3.3
Fix Version/s: 3.2.1
Component/s: Themes
Labels:
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Master Branch:
~~MDL-57319~~-master
Pull Master Diff URL:
https://github.com/danpoltawski/moodle/compare/5ef81f2b0b...MDL-57319-master
Testing Instructions:
Hide

Before applying patch please get into a 'broken' state so you know it will be fixed.

In your php.ini set max_execution_time = 5

Use boost and purge caches
Ensure that you get blank styling (to check that the bug is fixed). If you don't, try and lower execution time further.

Apply the patch/upgrade to with fix..

VERIFY: styling is produced
Show
Before applying patch please get into a 'broken' state so you know it will be fixed. In your php.ini set max_execution_time = 5 Use boost and purge caches Ensure that you get blank styling (to check that the bug is fixed). If you don't, try and lower execution time further. Apply the patch/upgrade to with fix.. VERIFY: styling is produced

Description

I have seen a few reports in the forums of people switching to boost and getting blank CSS.. my gut feeling is that its related to exectution time timing out during compilation on slower servers. You can reproduce it like this:

In php.ini max_execution_time = 5
Use boost/purge caches

Get blank css.

We should raise the execution time because scss compilation is known to be slow

Attachments

Activity

People

Assignee:: Dan Poltawski

Reporter:: Dan Poltawski

Peer reviewer:: Ankit Agarwal

Integrator:: Eloy Lafuente (stronk7)

Tester:: Damyon Wiese

Participants:: Ankit Agarwal, CiBoT, Damyon Wiese, Dan Poltawski, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Frédéric Massart, Matteo Scaramuccia, Nicolas Martignoni

Component watchers:: Huong Nguyen, Bas Brands, Mathew May

Votes:: 2 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 09/Dec/16 4:34 AM

Updated:: 16/Dec/16 1:38 AM

Resolved:: 16/Dec/16 1:38 AM

Fix Release Date:: 9/Jan/17