Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57319

Time limit needs raising for scss compilation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.3
    • Fix Version/s: 3.2.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Before applying patch please get into a 'broken' state so you know it will be fixed.

      1. In your php.ini set max_execution_time = 5
      2. Use boost and purge caches
        Ensure that you get blank styling (to check that the bug is fixed). If you don't, try and lower execution time further.

      Apply the patch/upgrade to with fix..

      VERIFY: styling is produced

      Show
      Before applying patch please get into a 'broken' state so you know it will be fixed. In your php.ini set max_execution_time = 5 Use boost and purge caches Ensure that you get blank styling (to check that the bug is fixed). If you don't, try and lower execution time further. Apply the patch/upgrade to with fix.. VERIFY: styling is produced
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57319-master

      Description

      I have seen a few reports in the forums of people switching to boost and getting blank CSS.. my gut feeling is that its related to exectution time timing out during compilation on slower servers. You can reproduce it like this:

      1. In php.ini max_execution_time = 5
      2. Use boost/purge caches

      Get blank css.

      We should raise the execution time because scss compilation is known to be slow

        Attachments

          Activity

            People

            Assignee:
            poltawski Dan Poltawski
            Reporter:
            poltawski Dan Poltawski
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Damyon Wiese
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jan/17