Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57321

theme_boost: Invalid HTML on course page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      For these tests you need to inspect the generated markup (as in, right click the page and view the source, rather than using the browser's dev tools). Please note we are mostly checking attributes as a whole for this issue, there may be other issues with the attribute values, but that isn't what this issue is about.

      As you browse around please also verify:

      1. There are no ul tags inside ul tags
      2. There are no aria attributes are duplicated

      On boost and clean (unless otherwise specified):

      1. Visit any page with admin settings ("Site administration" > "Badges" > "Badges settings" for example)
      2. Look for markup that matches:<div class="form-text defaultsnext"> immediately followed by <input type="text...
      3. Verify that the attributes on the input element are all properly separated by spaces and there are no extra spaces anywhere.
      4. View the generated markup for the user menu (you can search for "actionmenuaction" to find it)
      5. Verify that the a element's attributes are all properly separated by spaces and there are no extra spaces anywhere
      6. Check the generated markup for an action menu (you can find one by searching for 'div class="action-menu"'
      7. Verify that the attributes on the action menu div are all properly separated by spaces and there are no extra spaces anywhere
      8. Go to a course page in boost and check the generated markup for the "cog" menu
      9. Verify that the a element's attributes are all properly separated by spaces and there are no extra spaces anywhere
      10. On clean, create a chat activity and view it. Inspect the generated markup for the "Click here to enter the chat now" link
      11. Verify that the a element's attributes are all properly separated by spaces and there are no extra spaces anywhere
      12. Check the markup for an icon (search for 'class="icon"')
      13. Verify that the img element's attributes are all properly separated by spaces and there are no extra spaces anywhere
      14. Create a database activity and add a date field
      15. Add an entry to the database and view it
      16. Inspect the generated markup for the drop down selects
      17. Verify that the select element's attributes are all properly separated by spaces and there are no extra spaces anywhere
      18. On boost inspect the markup generated for various dropdown menus (the cog, the user menu, language menu etc)
      19. Verify that there are no div elements inside span elements
      Show
      For these tests you need to inspect the generated markup (as in, right click the page and view the source, rather than using the browser's dev tools). Please note we are mostly checking attributes as a whole for this issue, there may be other issues with the attribute values, but that isn't what this issue is about. As you browse around please also verify: There are no ul tags inside ul tags There are no aria attributes are duplicated On boost and clean (unless otherwise specified): Visit any page with admin settings ("Site administration" > "Badges" > "Badges settings" for example) Look for markup that matches: <div class="form-text defaultsnext"> immediately followed by <input type="text... Verify that the attributes on the input element are all properly separated by spaces and there are no extra spaces anywhere. View the generated markup for the user menu (you can search for "actionmenuaction" to find it) Verify that the a element's attributes are all properly separated by spaces and there are no extra spaces anywhere Check the generated markup for an action menu (you can find one by searching for 'div class="action-menu"' Verify that the attributes on the action menu div are all properly separated by spaces and there are no extra spaces anywhere Go to a course page in boost and check the generated markup for the "cog" menu Verify that the a element's attributes are all properly separated by spaces and there are no extra spaces anywhere On clean, create a chat activity and view it. Inspect the generated markup for the "Click here to enter the chat now" link Verify that the a element's attributes are all properly separated by spaces and there are no extra spaces anywhere Check the markup for an icon (search for 'class="icon"') Verify that the img element's attributes are all properly separated by spaces and there are no extra spaces anywhere Create a database activity and add a date field Add an entry to the database and view it Inspect the generated markup for the drop down selects Verify that the select element's attributes are all properly separated by spaces and there are no extra spaces anywhere On boost inspect the markup generated for various dropdown menus (the cog, the user menu, language menu etc) Verify that there are no div elements inside span elements
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57321-master

      Description

      There's a few instances of invalid HTML on course pages.

      https://qa.moodle.net/course/view.php?id=7

      The same errors pop up several times but probably can be traced back to a handful of minor errors that get called repeatedly, examples of each kind are:

      No space between two attributes:

      <div class="action-menu moodle-actionmenu nowrap-items" id="action-menu-1"data-enhance="moodle-core-actionmenu">
       
              <div class="menubar" id="action-menu-1-menubar"role="menubar">
      

      Element div not allowed as a child of a span tag:

      <span class="dropdown> ...
      <div class="dropdown-menu dropdown-menu-right menu  align-tr-br" id="action-menu-1-menu"
      

      duplicate attribute "class":

      <img class="icon " class="iconsmall" 
      

      There's some broken lists that have a UL class directly within another UL in the footer, but not sure if that's just been added via a WYSIWYG editor or not as the HTML is generally malformed, testing on a clean dev site should show whether that is the case or not.

      There's also a couple of warnings about the use of aria, that should be looked at.

        Attachments

        1. boost-MDL-57321.png
          boost-MDL-57321.png
          34 kB
        2. clean-MDL-57321.png
          clean-MDL-57321.png
          25 kB
        3. dropdown-after.png
          dropdown-after.png
          10 kB
        4. dropdown-before.png
          dropdown-before.png
          11 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Mar/17