Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57324

objectives score.raw should not trigger grade update

    XMLWordPrintable

Details

    • MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • master_MDL-57324
    • Easy
    • Hide

      hard to test - but it should be sufficient to use a SCORM package that passes a raw.score to Moodle and check to make sure that value ends up in the gradebook.

      Show
      hard to test - but it should be sufficient to use a SCORM package that passes a raw.score to Moodle and check to make sure that value ends up in the gradebook.

    Description

      in scorm_insert_track we check if the score or completion status has been changed before triggering the scorm_update_grades.

      this code:
      if (strstr($element, '.score.raw') ||

      was used instead of explicitly stating the scorm 1.2 and 2004 variables which both use that suffix but a slightly different prefix. The problem is that this will also trigger an update when a scorm package contains objectives which can also have a similar suffix:
      cmi.objectives.n.score.raw

      packages that use objectives will often contain a large number of objectives - which means on exit of the scorm package we could end up triggering a grade update at times that we shouldn't need to.

      Attachments

        Activity

          People

            danmarsden Dan Marsden
            danmarsden Dan Marsden
            Ankit Agarwal Ankit Agarwal
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Rajesh Taneja Rajesh Taneja
            Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Jan/17