Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57362

Assignment list all submissions page does not respect separate groups mode

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a couse.
      2. Enrol Four non-editing teachers.
      3. Create two groups and put one non-editing teacher in each on. Put the third non-editing teacher in both groups, and the fourth one in no groups.
      4. Put some students in both groups.
      5. Create an assignment.
        • Set group mode to "Separate groups"
      6. Go to the course and then follow "Course administration ► Users ► Permissions". Remove non-editing teachers from moodle/site:accessallgroups
      7. Log in as one of the non-editing teachers. Go to the assignment and the grading interface. Click on "View all submissions"
      8. In the student list check that you only have access to students in your group.
      9. Log in as the non-editing teacher that is a member of two groups.
      10. Go to the all submissions page. On the first page there should be a group selector. Stick with the first group.
      11. Make sure you only have access to the group selected on the previous screen.
      12. Select the other group. Check that you now only have access to the members of that group.
      13. Login as the fourth non-editing teacher and go back to the grading screen, you should see an permission error.
      14. Log in as a normal (editing) teacher and check that you have access to all students in the grading interface.

      Regression testing.

      1. Now change the group settings to "Visible groups" and log in as one of the non-editing teachers.
      2. Make sure that you have access to all of the groups in the assignment grading interface.
      3. Now change the groups settings to "No groups" and log in as one of the non-editing teachers.
      4. Make sure that you have access to all of the groups in the assignment grading interface.
      Show
      Create a couse. Enrol Four non-editing teachers. Create two groups and put one non-editing teacher in each on. Put the third non-editing teacher in both groups, and the fourth one in no groups. Put some students in both groups. Create an assignment. Set group mode to "Separate groups" Go to the course and then follow "Course administration ► Users ► Permissions". Remove non-editing teachers from moodle/site:accessallgroups Log in as one of the non-editing teachers. Go to the assignment and the grading interface. Click on "View all submissions" In the student list check that you only have access to students in your group. Log in as the non-editing teacher that is a member of two groups. Go to the all submissions page. On the first page there should be a group selector. Stick with the first group. Make sure you only have access to the group selected on the previous screen. Select the other group. Check that you now only have access to the members of that group. Login as the fourth non-editing teacher and go back to the grading screen, you should see an permission error. Log in as a normal (editing) teacher and check that you have access to all students in the grading interface. Regression testing. Now change the group settings to "Visible groups" and log in as one of the non-editing teachers. Make sure that you have access to all of the groups in the assignment grading interface. Now change the groups settings to "No groups" and log in as one of the non-editing teachers. Make sure that you have access to all of the groups in the assignment grading interface.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57362-master
    • Sprint:
      3.3 sprint 4

      Description

      This looks like a case that was missed when MDL-56363 was fixed. Steps to reproduce:

      1. You need a course with some students in groups, and a non-editing teacher who is in no groups.
      2. Create an assignment, set it to separate groups mode.
      3. A the non-editing teacher, go to the assignment, and click the View all submisisons button.

      Expected result: no students shown.

      Actual result: all students shown.

      This is a data-protection issue.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Mar/17