Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57380

Behat failure while checking ordered/unordered list created by Atto

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Install chrome 51.0
      2. Run failing behat tests as mentioned in description and ensure they pass.

      FYI: You can use following provided behat site use your ip.
      docker run -ti -p 4444:4444 rajeshtaneja/selenium:2.53.1 4444

      Show
      Install chrome 51.0 Run failing behat tests as mentioned in description and ensure they pass. FYI: You can use following provided behat site use your ip. docker run -ti -p 4444:4444 rajeshtaneja/selenium:2.53.1 4444
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      wip-mdl-57380

      Description

      With old chrome 51.0 Atto adds a span in list, so don't expect <ul><li>. Following behat is failing.

      001 Scenario: Make a list from some text                                     # /var/www/html/moodle/lib/editor/atto/plugins/orderedlist/tests/behat/orderedlist.feature:6
            Then I should see "<ol><li>Have you heard the news everyone's talking" # /var/www/html/moodle/lib/editor/atto/plugins/orderedlist/tests/behat/orderedlist.feature:19
              "<ol><li>Have you heard the news everyone's talking" text was not found in the page (Behat\Mink\Exception\ExpectationException)
       
      002 Scenario: Make a list from some text              # /var/www/html/moodle/lib/editor/atto/plugins/unorderedlist/tests/behat/unorderedlist.feature:6
            Then I should see "<ul><li>Things, dogs, clogs" # /var/www/html/moodle/lib/editor/atto/plugins/unorderedlist/tests/behat/unorderedlist.feature:19
              "<ul><li>Things, dogs, clogs" text was not found in the page (Behat\Mink\Exception\ExpectationException)
      

      On chrome 51.0 if you test above it adds a span and create list as
      <ol><li><span style="font-size: 1rem; line-height: 1.25;">Things, dogs, clogs, they're awesome</span><br></li><li><span style="font-size: 1rem; line-height: 1.25;">Rocks, clocks, and socks, they're awesome</span><br></li><li><span style="font-size: 1rem; line-height: 1.25;">Figs, and wigs, and twigs, that's awesome</span><br></li><li><span style="font-size: 1rem; line-height: 1.25;">Everything you see or think or say is awesome</span><br></li></ol>

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/17