Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57385

Boost: Breadcrumbs missing on mydashboard pages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Badges
      1. Make sure you're on Boost theme.
      2. Login as a student/teacher
      3. Click on the user menu and select "Preferences"
      4. Click on the "Manage badges" link.
        • Confirm that the page has a breadcrumb navigation.
      5. Switch to Clean theme and compare this page's layout with 3.2 stable.
        • Confirm that the layouts look similar.
      6. Go back to the user's preferences page and click "Backpack settings"
      7. Compare this page's layout with 3.2 stable.
        • Confirm that the layouts look similar.
      8. Switch again to Boost theme.
        • Confirm that the page has a breadcrumb navigation.
      Repository
      1. Login as an admin.
      2. Make sure you're on Boost theme.
      3. Navigate to "Site administration / Plugins / Repositories / Manage repositories"
      4. Make the "File system" repository enabled and visible.
      5. Tick "Allow admins to add a file system repository instance to a course (configurable only by admins)" and "Allow admins to add a file system repository instance for personal use (configurable only by admins)".
      6. Click "Save"
      7. Click on the admin's user menu and select "Preferences"
      8. Under the Repositories section, click "Manage instances"
        • Confirm that the page has breadcrumb navigation.
      9. Switch to Clean theme.
      10. Compare this page's layout with 3.2 stable.
        • Confirm that the layouts look similar.
      Private files
      1. Login as a student or admin
      2. Make sure you're on Boost theme.
      3. On the flat navigation panel, click "Private files"
        • Confirm that the page has breadcrumb navigation.
      4. Switch to Clean theme.
      5. Compare this page's layout with 3.2 stable.
        • Confirm that the layouts look similar.
      Show
      Badges Make sure you're on Boost theme. Login as a student/teacher Click on the user menu and select " Preferences " Click on the " Manage badges " link. Confirm that the page has a breadcrumb navigation. Switch to Clean theme and compare this page's layout with 3.2 stable. Confirm that the layouts look similar. Go back to the user's preferences page and click " Backpack settings " Compare this page's layout with 3.2 stable. Confirm that the layouts look similar. Switch again to Boost theme. Confirm that the page has a breadcrumb navigation. Repository Login as an admin. Make sure you're on Boost theme. Navigate to " Site administration / Plugins / Repositories / Manage repositories " Make the " File system " repository enabled and visible. Tick " Allow admins to add a file system repository instance to a course (configurable only by admins) " and " Allow admins to add a file system repository instance for personal use (configurable only by admins) ". Click " Save " Click on the admin's user menu and select " Preferences " Under the Repositories section, click " Manage instances " Confirm that the page has breadcrumb navigation. Switch to Clean theme. Compare this page's layout with 3.2 stable. Confirm that the layouts look similar. Private files Login as a student or admin Make sure you're on Boost theme. On the flat navigation panel, click " Private files " Confirm that the page has breadcrumb navigation. Switch to Clean theme. Compare this page's layout with 3.2 stable. Confirm that the layouts look similar.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57385-master-2
    • Sprint:
      3.3 sprint 1

      Description

      Since MDL-57124, the "nonavbar" page layout option was applied to the "mydashboard" page layout of theme_boost. The following pages that use the mydashboard page layout no longer have breadcrumbs:

      1. Default Dashboard page
      2. User preferences -> Badges -> Manage badges
      3. User preferences -> Badges -> Backpack settings
      4. User preferences -> Repositories -> Manage instances
      5. Private files

      I can think of 2 solutions for this issue:

      1. Use/create a different page layout for these pages (e.g. "standard"). Or,
      2. Introduce a new page layout option (e.g. "nonavbarifroot") that we can use to conditionally render the navbar if it contains more than one item.

      Any other great ideas for solutions are also welcome.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Mar/17