Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57387

When scss fails to compile, we should fall back to something good

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: HTML and CSS, Themes
    • Labels:

      Description

      In MDL-56488 I chose to fix only one case of problematic scss - user inputted scss which was not parsable.

      It did not fix when a scss varaible is used but not defined or other such errors. And even if we did detect that in the config setting, it wouldn't stop the case where a core scss change breaks this.

      Instead I think the solution is that when core fails to parse scss, it should take action to fall back to previously working scss and notify about the invalid value.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                poltawski Dan Poltawski
                Participants:
                Component watchers:
                Amy Groshek, David Scotson, Bas Brands, Ryan Wyllie, Bas Brands, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: