Loading...

XML

Word

Printable

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-57402~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-57402
Testing Instructions:
Hide

The Behat test is probably sufficient (I verifed it failed before fixing the JavaScript) but here are the steps if you want to do it manually.

Create a new course

Create a quiz

Add 11 questions, one on each page.

Use the remove page-break icon to remove the page-break between pages 10 and 11.

From the Add menu for page 10, choose a new section heading.
Show
The Behat test is probably sufficient (I verifed it failed before fixing the JavaScript) but here are the steps if you want to do it manually. Create a new course Create a quiz Add 11 questions, one on each page. Use the remove page-break icon to remove the page-break between pages 10 and 11. From the Add menu for page 10, choose a new section heading.

Thanks to Antonia Bonaccorso for reporting this in the forum, and patiently explaining to me how to reproduce it.

On https://qa.moodle.net/course/view.php?id=7, or any new course, as teacher.
Add 11 questions to a quiz, one on each page.
Use the remove page-break icon to remove the page-break between pages 10 and 11.
From the Add menu for page 10, choose a new section heading.

Expected result: page reloads with the new head.

Actual result: Error: Column 'firstslot' cannot be null

If you look at the HTTP traffic, you can see the problem is a request /mod/quiz/edit.php?cmid=977&addsectionatpage=100 (when it should be 10).

The problem is, the JavaScript that updates the page after altering page-breaks incorrectly handles two-digit page-breaks.

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eric Merrill, Ryan Wyllie, Tim Hunt