Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57404

Allow # comments in ip block / admin_setting_configiplist

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1.  Log in as a system administrator
      2. Browse to the ip blocker page: /admin/settings.php?section=ipblocker
      3. Set the 'Blocked IP List' to '192.200.51.11 # your comment here'
      4. Save changes, and notice that the value is saved
      5. Set the 'Blocked IP List' to 'YOUR_IP_ADDRESS # your comment here'
      6. Save changes, and notice that you are blocked from your site
      7. Restore access by updating the DB directly:

      update mdl_config set value = '' where name = 'blockedip';

      and then purging your caches:

      sudo -u www-data php admin/cli/purge_caches.php

      Show
       Log in as a system administrator Browse to the ip blocker page: /admin/settings.php?section=ipblocker Set the 'Blocked IP List' to '192.200.51.11 # your comment here' Save changes, and notice that the value is saved Set the 'Blocked IP List' to 'YOUR_IP_ADDRESS # your comment here' Save changes, and notice that you are blocked from your site Restore access by updating the DB directly: update mdl_config set value = '' where name = 'blockedip'; and then purging your caches: sudo -u www-data php admin/cli/purge_caches.php
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      mdl57404

      Description

      It would be very useful to be able to add comments to ip lists in moodle. Use cases would be to document what an ip is eg:

      123.234.345.456 # acme.com staff
      

      Or to temporarily remove item's but not delete them:

      # 123.234.345.456 # acme.com staff
      

        Attachments

          Activity

            People

            Assignee:
            egiles Evan Giles
            Reporter:
            brendanheywood Brendan Heywood
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Jake Dallimore
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Dec/18