[MDL-57404] Allow # comments in ip block / admin_setting_configiplist - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Log in as a system administrator

Browse to the ip blocker page: /admin/settings.php?section=ipblocker

Set the 'Blocked IP List' to '192.200.51.11 # your comment here'

Save changes, and notice that the value is saved

Set the 'Blocked IP List' to 'YOUR_IP_ADDRESS # your comment here'

Save changes, and notice that you are blocked from your site

Restore access by updating the DB directly:

update mdl_config set value = '' where name = 'blockedip';

and then purging your caches:

sudo -u www-data php admin/cli/purge_caches.php
Show
Log in as a system administrator Browse to the ip blocker page: /admin/settings.php?section=ipblocker Set the 'Blocked IP List' to '192.200.51.11 # your comment here' Save changes, and notice that the value is saved Set the 'Blocked IP List' to 'YOUR_IP_ADDRESS # your comment here' Save changes, and notice that you are blocked from your site Restore access by updating the DB directly: update mdl_config set value = '' where name = 'blockedip'; and then purging your caches: sudo -u www-data php admin/cli/purge_caches.php
Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Pull from Repository:
https://github.com/egiles/moodle.git
Pull Master Branch:
mdl57404
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...egiles:mdl57404

It would be very useful to be able to add comments to ip lists in moodle. Use cases would be to document what an ip is eg:

123.234.345.456 # acme.com staff

Or to temporarily remove item's but not delete them:

# 123.234.345.456 # acme.com staff

Participants:: Adrian Greeve, Brendan Heywood, CiBoT, Eloy Lafuente (stronk7), Evan Giles, Jake Dallimore

Component watchers:: Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze