Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57412

Respect "linkcoursesections" setting in boost

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Upgrade tests

      You will need 3 instances based off last weekly release total. Or you can simply checkout last week's weekly release and run mdk run version and set linkcoursesections to 'No' each time. That will be enough to ensure full coverage of the upgrade step. Normally you can't do such things for an upgrade test though

      1. Select it as the site wide theme
      2. Go to Site administration > Appearance > Navigation
      3. Make sure linkcoursesections is ticked and now defaults to yes
      4. Install/use a different instance based on the last weekly release
      5. Make sure linkcoursesections is not ticked
      6. Choose boost as the theme
      7. Upgrade
      8. Make sure linkcoursesections is still not ticked
      9. Install/use yet another different instance based on the last weekly release
      10. Make sure linkcoursesections is not ticked
      11. Choose clean as the theme
      12. Upgrade
      13. Make sure linkcoursesections is still not ticked

      For all following tests, test in both boost and clean. No need to worry about the other theme you just downloaded. It only effects the upgrade step.

      All sections on page test

      1. Go to Site administration ▶︎ Appearance ▶︎ Navigation
      2. Make sure linkcoursesections is off
      3. Create 3 courses, one with topics format, one with weekly format and one with the plugin format you downloaded
      4. In the topics course make sure you don't see the section titles as links
      5. Make sure you don't see section links on the left in boost (and see the sections, but no links in clean)
      6. Turn editing on and make sure in place editing works correctly (keeping no link)
      7. In the dates course make sure you don't see the section titles as links
      8. Make sure you don't see section links on the left in boost (and see the sections, but no links in clean)
      9. Turn editing on and make sure in place editing works correctly (keeping no link)
      10. Go to Site administration ▶︎ Appearance ▶︎ Navigation
      11. Turn linkcoursesections on
      12. In the topics course make sure you see the section titles as links
      13. And make sure you see the section links in both themes in flatnav or the navtree
      14. Turn editing on and make sure in place editing works correctly (keeping the link)
      15. In the dates course make sure you see the section titles as links
      16. And make sure you see the section links in both themes in flatnav or the navtree
      17. Turn editing on and make sure in place editing works correctly (keeping the link)
      18. In the plugin course make sure you see the section titles as links
      19. And make sure you see the section links in both themes in flatnav or the navtree

      One section per page test

      1. For the courses select "Course layout" as "One section per page"
      2. Click a section. Once you are on the section make sure it's not linked
      3. Test in place editing again
      4. Repeat for all courses
      5. Go to Site administration ▶︎ Appearance ▶︎ Navigation
      6. Turn linkcoursesections off
      7. Go back to the courses
      8. Make sure the sections are links and you can click a section. Once you are on the section make sure it's not linked
      9. Test in place editing again
      10. Repeat for all courses

      Return to course

      1. Create a feedback activity
      2. Add a question
      3. As a student, take the feedback and press continue at the end
      4. Make sure you are returned to the course with no errors

      Final upgrade test

      1. On the last 32 weekly, set your linkcoursesections to 0, make sure the theme is boost
      2. Upgrade to integration
      3. linkcoursesections should be 1
      4. Set it to 0 again
      5. Upgrade to 33 integration
      6. linkcoursesections should be 0
      7. Upgrade to master integration
      8. linkcoursesections should be 0
      Show
      Upgrade tests You will need 3 instances based off last weekly release total. Or you can simply checkout last week's weekly release and run mdk run version and set linkcoursesections to 'No' each time. That will be enough to ensure full coverage of the upgrade step. Normally you can't do such things for an upgrade test though Select it as the site wide theme Go to Site administration > Appearance > Navigation Make sure linkcoursesections is ticked and now defaults to yes Install/use a different instance based on the last weekly release Make sure linkcoursesections is not ticked Choose boost as the theme Upgrade Make sure linkcoursesections is still not ticked Install/use yet another different instance based on the last weekly release Make sure linkcoursesections is not ticked Choose clean as the theme Upgrade Make sure linkcoursesections is still not ticked For all following tests, test in both boost and clean. No need to worry about the other theme you just downloaded. It only effects the upgrade step. All sections on page test Go to Site administration ▶︎ Appearance ▶︎ Navigation Make sure linkcoursesections is off Create 3 courses, one with topics format, one with weekly format and one with the plugin format you downloaded In the topics course make sure you don't see the section titles as links Make sure you don't see section links on the left in boost (and see the sections, but no links in clean) Turn editing on and make sure in place editing works correctly (keeping no link) In the dates course make sure you don't see the section titles as links Make sure you don't see section links on the left in boost (and see the sections, but no links in clean) Turn editing on and make sure in place editing works correctly (keeping no link) Go to Site administration ▶︎ Appearance ▶︎ Navigation Turn linkcoursesections on In the topics course make sure you see the section titles as links And make sure you see the section links in both themes in flatnav or the navtree Turn editing on and make sure in place editing works correctly (keeping the link) In the dates course make sure you see the section titles as links And make sure you see the section links in both themes in flatnav or the navtree Turn editing on and make sure in place editing works correctly (keeping the link) In the plugin course make sure you see the section titles as links And make sure you see the section links in both themes in flatnav or the navtree One section per page test For the courses select "Course layout" as "One section per page" Click a section. Once you are on the section make sure it's not linked Test in place editing again Repeat for all courses Go to Site administration ▶︎ Appearance ▶︎ Navigation Turn linkcoursesections off Go back to the courses Make sure the sections are links and you can click a section. Once you are on the section make sure it's not linked Test in place editing again Repeat for all courses Return to course Create a feedback activity Add a question As a student, take the feedback and press continue at the end Make sure you are returned to the course with no errors Final upgrade test On the last 32 weekly, set your linkcoursesections to 0, make sure the theme is boost Upgrade to integration linkcoursesections should be 1 Set it to 0 again Upgrade to 33 integration linkcoursesections should be 0 Upgrade to master integration linkcoursesections should be 0
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57412-master
    • Sprint:
      3.4 Sprint 4

      Description

      In Site administration >Appearance>Navigation, the setting "Always link course sections" linkcoursesections does not change whether the option is ticked or not. Previously you could decide whether or not sections would be linked. Now - whether you use Boost or Clean, it appears the sections are always linked.
      Is this a regression or deliberate? If deliberate, then the setting should be removed. If it's a regression, then it would be good to have it fixed as it has been noticed in the forums -see https://moodle.org/mod/forum/discuss.php?d=344429#p1388768

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                17 Vote for this issue
                Watchers:
                18 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Sep/17