Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26254 $CFG->perfdebug uses confusing values
  3. MDL-57427

Moodle always enables performance debugging in MUC

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.0.7, 3.1.3, 3.2
    • 3.1.5, 3.2.2
    • Caching, Performance
    • MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • Hide

      The commit adds a test case that only works with the fix applied.

      Add the following lines to your config.php:

      define('MDL_PERF', true);
      define('MDL_PERFTOFOOT', true);
      $CFG->perfdebug = 15; // should have lots of caching output in the footer
      

      Now switch off performance debugging:

      define('MDL_PERF', true);
      define('MDL_PERFTOFOOT', true);
      $CFG->perfdebug = 7; // should say "Caches used (hits/misses/sets): 0/0/0"
      

      Show
      The commit adds a test case that only works with the fix applied. Add the following lines to your config.php: define( 'MDL_PERF' , true); define( 'MDL_PERFTOFOOT' , true); $CFG ->perfdebug = 15; // should have lots of caching output in the footer Now switch off performance debugging: define( 'MDL_PERF' , true); define( 'MDL_PERFTOFOOT' , true); $CFG ->perfdebug = 7; // should say "Caches used (hits/misses/sets): 0/0/0"

    Description

      The values of $CFG->perfdebug that can be set through the interface are 7 and 15 . All other uses of perfdebug through Moodle do a check to make sure the value is greater than 7, except for the MUC.

      Attachments

        Activity

          People

            jrchamp Jonathan Champ
            jrchamp Jonathan Champ
            Adrian Greeve Adrian Greeve
            Dan Poltawski Dan Poltawski
            Rajesh Taneja Rajesh Taneja
            Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/Mar/17