Moodle
  1. Moodle
  2. MDL-5745

problem creating localised en_utf8_local with language tool

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: None
    • Component/s: Language
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE
    • Rank:
      14863

      Description

      It doesn't seem possible to create a localised En language pack with the 'switch' button (although it works perfect for other languages)

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          From Harry Smith (bft4trng at yahoo.com.au) Thursday, 8 June 2006, 07:18 AM:

          Thanks for confirming Koen, I thought it was just me as per the thread at http://moodle.org/mod/forum/discuss.php?d=47236.

          From Eloy Lafuente (stronk7 at moodle.org) Friday, 9 June 2006, 07:30 AM:

          Some questions about this:

          • should be en_utf8 editable or no? Perhaps the message should be that it isn't editable at all?
          • what's the switch button you talked about in your previous post?

          Just wondering... to know a bit more about the problem... ciao

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Friday, 9 June 2006, 04:56 PM:

          I've just fixed the bug, see revision 1.67. As en_utf8 is prevented from editing (which is IMHO OK) the script did not allow edit nor _local pack.

          Bug Status changed to Resolved, please Verify and Close.

          From Eloy Lafuente (stronk7 at moodle.org) Monday, 12 June 2006, 01:42 AM:

          Hi,

          am I wrong an all these changes are only available under HEAD? Shouldn't them be under MOODLE_16_STABLE too?

          Ciao

          From oen roggemans (koen at roggemans.net) Monday, 12 June 2006, 02:31 AM:

          Good thinking. Yes they should. Can someone with write rights merge them please?

          From Eloy Lafuente (stronk7 at moodle.org) Tuesday, 13 June 2006, 08:12 PM:

          Hi David, could you do that?

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Saturday, 17 June 2006, 03:29 AM:

          As we have discussed an the forum these improvements were commited after 1.6 was in beta stage. We decided to respect general rule that no new features are being included into beta version - only bug fixes. Probably I am wrong but what would happen after merging into MOODLE_16_STABLE? What is the difference between MOODLE_16_STABLE and MOODLE_16_BETA tags?

          Sorry for stupid questions but I do not want to mess up stable code with this new stuff... So thank you for any explanation

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Saturday, 17 June 2006, 03:32 AM:

          Please note at http://download.moodle.org/

          Standard Moodle Distribution - Moodle 1.6 Beta - MOODLE_16_BETA

          Complete Install Packages - Moodle 1.6 Beta - MOODLE_16_STABLE

          So what is the difference between these tags?

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Tuesday, 20 June 2006, 03:44 AM:

          MOODLE_16_STABLE is a branch and MOODLE_16_BETA is a forking tag... I see now. How I love and miss Subversion here

          So - when should the new lang.php be merged into _STABLE branch? I would prefer to release it in 1.6.1

          From Timothy Allen (scop at hannam.ac.kr) Friday, 7 July 2006, 04:15 PM:

          I have tested this in Moodle 1.6 stable and it doesn't seem to work. When one clicks on a link the new lang.php a page from the Moodle CVS repository pops up!

          I have attached a screenshot as an example.

          FWIW I think when this is finally fixed it should go straight into 1.6 stable, as it is a critical bug fix (for those doing language customization) and not a new feature.

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Saturday, 8 July 2006, 06:19 AM:

          hi scop,

          can you please describe what link took you to the attached page? I can not imagine why an Moodle script could lead you into CVS repository browser 8-o

          From Timothy Allen (scop at hannam.ac.kr) Sunday, 9 July 2006, 06:59 PM:

          In the screenshot that I attached you can see that the link was admin/lang.php. It happened when I:

          • clicked on the language link from the Adminstraion --> Configuration screen
          • clicked on either the Check for missing strings or Edit strings links in the Administration --> Confuguration --> Language screen (possible because I had gone there first and then replaced the new file).

          The screen which comes up - which you can see in the screenshot I added here also - is Log of /moodle/admin/lang.php and the browser title is SourceForge.net CVS Repository - [moodle] Log of /moodle/admin/lang.php. However, the address in the browser address bar is still http://tim.hannam.ac.kr/moodtrans/admin/lang.php?mode=compare (etc).

          Changing themes makes no difference - the problem occurs even on the standard theme.

          My specs are the following:

          Moodle 1.6 + (2006050506) on CentOS Linux with PHP 5.1.2, MySQL 4.1.20, Apache 2.0.55.

          But the same thing happened on Windows XP using the latest Moodle Xampp package from the Moodle download page.

          I even moved my CVS directory out of the admin directory but that made no difference.

          PS I cannot imagine why it would do that either! - unfortunately I am not a coder but I am happy to help you find the source of the problem.

          From Timothy Allen (scop at hannam.ac.kr) Sunday, 9 July 2006, 07:23 PM:

          Please ignore everything I said - it is a stupid mistake on my part:

          I download the lang.php from the Moodel CVS repository by right-clicking and selecting Save link as in Firefox. Instead of downloading the lang.php file, it saved a PHP file for the Sourceforge website instead.

          I should have clicked on the filename and then clicked on the download link to get the correct file. So all the problems occurred because I didn't download the file properly.

          I apologize for wasting your time.

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Sunday, 9 July 2006, 07:32 PM:

          No worries - to be honest, I thought it would be something like that I am happy that it is solved now, so I can report MartinD that the script can be considered stable.

          From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Sunday, 9 July 2006, 11:41 PM:

          The lang.php was just sent to MOODLE_16_STABLE.

          From Eloy Lafuente (stronk7 at moodle.org) Thursday, 13 July 2006, 03:58 AM:

          Cool! B-)

          Show
          Martin Dougiamas added a comment - From Harry Smith (bft4trng at yahoo.com.au) Thursday, 8 June 2006, 07:18 AM: Thanks for confirming Koen, I thought it was just me as per the thread at http://moodle.org/mod/forum/discuss.php?d=47236 . From Eloy Lafuente (stronk7 at moodle.org) Friday, 9 June 2006, 07:30 AM: Some questions about this: should be en_utf8 editable or no? Perhaps the message should be that it isn't editable at all? what's the switch button you talked about in your previous post? Just wondering... to know a bit more about the problem... ciao From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Friday, 9 June 2006, 04:56 PM: I've just fixed the bug, see revision 1.67. As en_utf8 is prevented from editing (which is IMHO OK) the script did not allow edit nor _local pack. Bug Status changed to Resolved, please Verify and Close. From Eloy Lafuente (stronk7 at moodle.org) Monday, 12 June 2006, 01:42 AM: Hi, am I wrong an all these changes are only available under HEAD? Shouldn't them be under MOODLE_16_STABLE too? Ciao From oen roggemans (koen at roggemans.net) Monday, 12 June 2006, 02:31 AM: Good thinking. Yes they should. Can someone with write rights merge them please? From Eloy Lafuente (stronk7 at moodle.org) Tuesday, 13 June 2006, 08:12 PM: Hi David, could you do that? From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Saturday, 17 June 2006, 03:29 AM: As we have discussed an the forum these improvements were commited after 1.6 was in beta stage. We decided to respect general rule that no new features are being included into beta version - only bug fixes. Probably I am wrong but what would happen after merging into MOODLE_16_STABLE? What is the difference between MOODLE_16_STABLE and MOODLE_16_BETA tags? Sorry for stupid questions but I do not want to mess up stable code with this new stuff... So thank you for any explanation From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Saturday, 17 June 2006, 03:32 AM: Please note at http://download.moodle.org/ Standard Moodle Distribution - Moodle 1.6 Beta - MOODLE_16_BETA Complete Install Packages - Moodle 1.6 Beta - MOODLE_16_STABLE So what is the difference between these tags? From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Tuesday, 20 June 2006, 03:44 AM: MOODLE_16_STABLE is a branch and MOODLE_16_BETA is a forking tag... I see now. How I love and miss Subversion here So - when should the new lang.php be merged into _STABLE branch? I would prefer to release it in 1.6.1 From Timothy Allen (scop at hannam.ac.kr) Friday, 7 July 2006, 04:15 PM: I have tested this in Moodle 1.6 stable and it doesn't seem to work. When one clicks on a link the new lang.php a page from the Moodle CVS repository pops up! I have attached a screenshot as an example. FWIW I think when this is finally fixed it should go straight into 1.6 stable, as it is a critical bug fix (for those doing language customization) and not a new feature. From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Saturday, 8 July 2006, 06:19 AM: hi scop, can you please describe what link took you to the attached page? I can not imagine why an Moodle script could lead you into CVS repository browser 8-o From Timothy Allen (scop at hannam.ac.kr) Sunday, 9 July 2006, 06:59 PM: In the screenshot that I attached you can see that the link was admin/lang.php. It happened when I: clicked on the language link from the Adminstraion --> Configuration screen clicked on either the Check for missing strings or Edit strings links in the Administration --> Confuguration --> Language screen (possible because I had gone there first and then replaced the new file). The screen which comes up - which you can see in the screenshot I added here also - is Log of /moodle/admin/lang.php and the browser title is SourceForge.net CVS Repository - [moodle] Log of /moodle/admin/lang.php. However, the address in the browser address bar is still http://tim.hannam.ac.kr/moodtrans/admin/lang.php?mode=compare (etc). Changing themes makes no difference - the problem occurs even on the standard theme. My specs are the following: Moodle 1.6 + (2006050506) on CentOS Linux with PHP 5.1.2, MySQL 4.1.20, Apache 2.0.55. But the same thing happened on Windows XP using the latest Moodle Xampp package from the Moodle download page. I even moved my CVS directory out of the admin directory but that made no difference. PS I cannot imagine why it would do that either! - unfortunately I am not a coder but I am happy to help you find the source of the problem. From Timothy Allen (scop at hannam.ac.kr) Sunday, 9 July 2006, 07:23 PM: Please ignore everything I said - it is a stupid mistake on my part: I download the lang.php from the Moodel CVS repository by right-clicking and selecting Save link as in Firefox. Instead of downloading the lang.php file, it saved a PHP file for the Sourceforge website instead. I should have clicked on the filename and then clicked on the download link to get the correct file. So all the problems occurred because I didn't download the file properly. I apologize for wasting your time. From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Sunday, 9 July 2006, 07:32 PM: No worries - to be honest, I thought it would be something like that I am happy that it is solved now, so I can report MartinD that the script can be considered stable. From David Mudrak (mudrd8mz at uxit.pedf.cuni.cz) Sunday, 9 July 2006, 11:41 PM: The lang.php was just sent to MOODLE_16_STABLE. From Eloy Lafuente (stronk7 at moodle.org) Thursday, 13 July 2006, 03:58 AM: Cool! B-)
          Hide
          Michael Blake added a comment -

          Assigning to a valid user.

          Show
          Michael Blake added a comment - Assigning to a valid user.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: