Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57464

Lessons with sub-clusters generates strict notices.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.1.4, 3.2.1
    • Component/s: Lesson
    • Labels:
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-57464-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      • Make sure to have debugging on.
      1. Create a lesson.
      2. Create a sub-cluster:
        1. Add A cluster with at least two question in it. Make sure to add an end of cluster page to mark the end of the cluster.
        2. With the questions have the correct answer jump to the cluster.
        3. Add a content page in the cluster and call it sub-cluster.
        4. Make the first jump go to the cluster.
        5. Add two numerical questions. Have the answer jump to the end of the branch.
        6. Add an end of branch page to show the end of the sub-cluster.
      3. Take the lesson as a student.
      4. Make sure that no notices are shown when taking the lesson.
      Show
      Make sure to have debugging on. Create a lesson. Create a sub-cluster: Add A cluster with at least two question in it. Make sure to add an end of cluster page to mark the end of the cluster. With the questions have the correct answer jump to the cluster. Add a content page in the cluster and call it sub-cluster. Make the first jump go to the cluster. Add two numerical questions. Have the answer jump to the end of the branch. Add an end of branch page to show the end of the sub-cluster. Take the lesson as a student. Make sure that no notices are shown when taking the lesson.

      Description

      When attempting a lesson with a sub-cluster as a student I get the following warning:

      Strict Standards: Only variables should be passed by reference in /home/adrian/moodles/stable_master_postgres/moodle/mod/lesson/pagetypes/endofbranch.php on line 61

      The fix is quite straightforward and has been attached.

        Attachments

          Activity

            People

            Assignee:
            abgreeve Adrian Greeve
            Reporter:
            abgreeve Adrian Greeve
            Peer reviewer:
            Ankit Agarwal Ankit Agarwal
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Rajesh Taneja Rajesh Taneja
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jan/17