Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57490

Remove old legacy global js functions

    Details

    • Testing Instructions:
      Hide
      1. Add a quiz and attempt it as a student
      2. As a teacher, view the attempts report
      3. VERIFY: the select all/deselect all link selects and unselects the checkboxes
      1. Add a lesson and attempt it as a student
      2. As a teacher go to the overview report
      3. VERIFY: the select all/deselect all link selects and unselects the checkboxes on the attempts
      1. Add a scorm activity and attempt it as a student
      2. As teacher go to scorm reports and repeat for Basic, Interactions, Objectives report
      3. VERIFY: the select all/deselect all link selects and unselects the checkboxes on the attempts
      Show
      Add a quiz and attempt it as a student As a teacher, view the attempts report VERIFY: the select all/deselect all link selects and unselects the checkboxes Add a lesson and attempt it as a student As a teacher go to the overview report VERIFY: the select all/deselect all link selects and unselects the checkboxes on the attempts Add a scorm activity and attempt it as a student As teacher go to scorm reports and repeat for Basic, Interactions, Objectives report VERIFY: the select all/deselect all link selects and unselects the checkboxes on the attempts
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-57490-master

      Description

      We've got a number of functions in javascript-static (e.g. checkall) which have been in the global namespace for nearly 14 years and are not appropiate to modern moodle

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                poltawski Dan Poltawski
                Reporter:
                poltawski Dan Poltawski
                Peer reviewer:
                Ryan Wyllie
                Integrator:
                Andrew Nicols
                Tester:
                Andrew Nicols
                Participants:
                Component watchers:
                Andrew Nicols, Ryan Wyllie, Adrian Greeve, Mihail Geshoski, Tim Hunt, Shamim Rezaie, Simey Lameze, Dan Marsden, Matteo Scaramuccia, David Mudrák, Sara Arjona
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17