Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57491

Origin filter cripples log reports on large sites

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Basic regression tests:

      1. Call cron from the CLI (php admin/cli/cron.php)
      2. Log into the site as an admin and navigate to Reports -> logs
      3. Filter the report by "all sources" verify you see events from both web and CLI
      4. Filter the report by "Web" and verify you only see events originating from the web
      5. Filter the report by "CLI" and verify you only see events originating from the cli
      6. Manually edit your data in the mdl_logstore_standard_log table changing the origin of 1-2 records to "Unknown"
      7. Filter the report by "Other" verify you see the events you edited in the previous step

      *Note: This patch introduces a new string, so you may need to purge caches.

      Show
      Basic regression tests: Call cron from the CLI (php admin/cli/cron.php) Log into the site as an admin and navigate to Reports -> logs Filter the report by "all sources" verify you see events from both web and CLI Filter the report by "Web" and verify you only see events originating from the web Filter the report by "CLI" and verify you only see events originating from the cli Manually edit your data in the mdl_logstore_standard_log table changing the origin of 1-2 records to "Unknown" Filter the report by "Other" verify you see the events you edited in the previous step *Note: This patch introduces a new string, so you may need to purge caches.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57491_m33v3

      Description

      A filter was added for origin/source to the log reports in MDL-50286. To build the list for that menu it does:

      select distinct origin from mdl_logstore_standard_log order by origin ASC
      

      But on large sites that is cripplingly slow - on every page load of the report.

      Unfortunately an index doesn't help this sort of query, at least on postgres. We tried.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sbourget Stephen Bourget
                Reporter:
                emerrill Eric Merrill
                Peer reviewer:
                Eric Merrill
                Integrator:
                David Monllaó
                Tester:
                Ankit Agarwal
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/17