Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57524

Input text size ignored, and input is too long, in RTL mode

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: Test on various browsers, such as IE, Edge, Firefox, Chrome and Safari.

      1. Make sure you are using theme Boost.
      2. Install an RTL language pack (e.g. Hebrew).
      3. Navigate into "Site administration > Plugins > Media players > Manage media players"
      4. Check the input fields.
        • Confirm that the width input fields with the "size" attribute obey the attribute.
      5. Switch to the RTL language (RTL mode).
        • Confirm that the width input fields with the "size" attribute obey the attribute.
      6. Go to "Site administration > Appearance > HTML settings"
      7. Check the input fields.
        • Confirm that the all the columns of the table are visible on the page.
      8. Do an exploratory testing of the site administration pages.
        • Confirm that the page layout and/or the appearance of the fields is not broken.
      Show
      Note: Test on various browsers, such as IE, Edge, Firefox, Chrome and Safari. Make sure you are using theme Boost. Install an RTL language pack (e.g. Hebrew). Navigate into "Site administration > Plugins > Media players > Manage media players" Check the input fields. Confirm that the width input fields with the " size " attribute obey the attribute. Switch to the RTL language (RTL mode). Confirm that the width input fields with the " size " attribute obey the attribute. Go to " Site administration > Appearance > HTML settings " Check the input fields. Confirm that the all the columns of the table are visible on the page. Do an exploratory testing of the site administration pages. Confirm that the page layout and/or the appearance of the fields is not broken.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57524_master

      Description

      As far as I checked, input type=text on all admin pages ignore size attribute. and so, in RTL mode, the value is too far off on the left, and is hard to see.
      Might even be some sort of accessibility issue.

      Seems we better change width from 100% to auto, to fix this. for both LTR and RTL.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Mar/17