Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57527

Remove yui2-dom uses

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2, 3.3
    • Fix Version/s: 3.3
    • Component/s: JavaScript, Reports
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable file download protofolio plugin
      2. Go to somewhere where you can export portfolio content (e.g. own forum post) and export the forum post as a file download
      3. Verify the file gets downloaded automatically and you don't get a 'download file button'
      1. Setup course completion in a course and activity compeletion on some activies. Make sure the course completion requires the activities to be complete
      2. View the completion report and progress report
      3. VERIFY: the activity titles are displayed relatively pleasantly as a rotated text (note that MDL-58044 has been created for RTL problems detected in the reports).
      Show
      Enable file download protofolio plugin Go to somewhere where you can export portfolio content (e.g. own forum post) and export the forum post as a file download Verify the file gets downloaded automatically and you don't get a 'download file button' Setup course completion in a course and activity compeletion on some activies. Make sure the course completion requires the activities to be complete View the completion report and progress report VERIFY: the activity titles are displayed relatively pleasantly as a rotated text (note that MDL-58044 has been created for RTL problems detected in the reports).
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-57527-master

      Description

      git grep yui2-dom -- './*' ':!lib/yuilib/**'
      portfolio/download/helper.js:YUI().use('yui2-dom', function(Y) {
      report/completion/textrotate.js:YUI().use('yui2-dom', function(Y) {
      report/progress/textrotate.js:YUI().use('yui2-dom', function(Y) {
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              David Mudrák (@mudrd8mz)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/17