[MDL-57576] Error "Can not create file" when sending the same feedback file to a student. - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/roperto/moodle.git
Pull Master Branch:
~~MDL-57576~~-33-updatefeedbackfile
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...roperto:MDL-57576-33-updatefeedbackfile
Testing Instructions:
Hide

Create an assignment (allow sending feedback files)

Select "View all submissions"

Select a student (via checkbox), and down the bottom of the page in the "With selected..." section select "Send feedback files"

Try again, same student, same file – it should fail without the patch, succeed after patch.

Extra test: send again another file, different contents, same name. As the student, you should get the new file instead of the old one.
Show
Create an assignment (allow sending feedback files) Select "View all submissions" Select a student (via checkbox), and down the bottom of the page in the "With selected..." section select "Send feedback files" Try again, same student, same file – it should fail without the patch, succeed after patch. Extra test: send again another file, different contents, same name. As the student, you should get the new file instead of the old one.

If you try to resend the same feedback file to a student, it fails due to:

ERROR: duplicate key value violates unique constraint "mdl_file_pat_uix"

The probable cause is not checking if the user already has that file before trying to copy again.

To reproduce:

1) Create an assignment (allow sending feedback files)

2) Select a student, send any file as a feedback file – it should succeed.

3) Try again, same student, same file – it should fail.

Participants:: Adrian Greeve, CiBoT, Daniel Thee Roperto, David Monllaó, Marina Glancy

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie