Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57583

Course Completion Settings not saving

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable completion on a course.
      2. Create two assignments, making sure to set 'Students can manually mark the activity as complete' when creating them.
      3. Now, go to course completion page (Cog menu in Boost).
        1. Under 'General', select '..ANY of conditions are met'.
        2. Under 'Activity completion', confirm that you see both activities.
        3. Select just the first activity and save the form.
      4. Go back in, and confirm that only the first value is checked. Check the course_completion_criteria table and confirm you only see one record (check courseid and module 'assign').
      5. Now, check the other checkbox (both checked now) and save the form.
      6. Go back in, and confirm that both values are checked. Check the course_completion_criteria table and confirm you only see both records.
      7. Now, de-select both checkboxes and save the form.
      8. Go back in, and confirm that no activities are checked. Check the course_completion_criteria table and confirm you see no records.
      9. Now, try using the 'select all/none' control to save with none or all checked. Confirm this works as expected too (Note MDL-52584)
      Show
      Enable completion on a course. Create two assignments, making sure to set 'Students can manually mark the activity as complete' when creating them. Now, go to course completion page (Cog menu in Boost). Under 'General', select '..ANY of conditions are met'. Under 'Activity completion', confirm that you see both activities. Select just the first activity and save the form. Go back in, and confirm that only the first value is checked. Check the course_completion_criteria table and confirm you only see one record (check courseid and module 'assign'). Now, check the other checkbox (both checked now) and save the form. Go back in, and confirm that both values are checked. Check the course_completion_criteria table and confirm you only see both records. Now, de-select both checkboxes and save the form. Go back in, and confirm that no activities are checked. Check the course_completion_criteria table and confirm you see no records. Now, try using the 'select all/none' control to save with none or all checked. Confirm this works as expected too (Note MDL-52584 )
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57583-master
    • Sprint:
      3.3 sprint 4

      Description

      When creating course completion setting to track course as complete if any of two different activities are completed, moodle is not saving the settings and revert to "Select all" activities.

      When saving the edit course completion settings page, the database is updated in the mdl_course_completion_criteria page with an entry for each of the activities that show as checked, despite the initial instruction to only create a criteria record for one or two of them. Deleting the row in that table associated with the activity ID's not desired fixes the issue. The problem seems to be with how the edit completion settings page saves the user input.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/May/17