Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57587

Feedback images when reviewing a quiz attempt not showing

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      For each of the following question types:

      • drag and drop onto image
      • drag and drop markers
      • drag and drop into text
      • select missing words
      • matching
      • mutlitple choice
      1. Ensure you have developer debug on.
      2. Create a question of this type, with an image in the 'Feedback for any correct response'
      3. Add the question to a quiz. (Ensure the review options say to show feedback.)
      4. Attempt the quiz as a student, and get the question right.
      5. Verify that the feedback is displayed, and that the image appears.
      Show
      For each of the following question types: drag and drop onto image drag and drop markers drag and drop into text select missing words matching mutlitple choice Ensure you have developer debug on. Create a question of this type, with an image in the 'Feedback for any correct response' Add the question to a quiz. (Ensure the review options say to show feedback.) Attempt the quiz as a student, and get the question right. Verify that the feedback is displayed, and that the image appears.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Commit cf0b943 for MDL-53744 modified the check_combined_feedback_file_access function of question/type/questionbase.php to do a check against $args, but $args is not passed through as a parameter.

      Consequently no feedback graphics (for general correct/incorrect/partiallycorrect feedback) are rendered when reviewing a quiz in gapselect, multichoice and match question types.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57779 file access checks always return false in combined feedback

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57860 Insert image in MC Quiz Combined Feedback displays broken/no image

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57904 Drag and drop marker generates multiple notices

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              rbkcapdm Richard Kirby
              Peer reviewer:
              Eric Merrill Eric Merrill
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Ankit Agarwal Ankit Agarwal
              Participants:
              Component watchers:
              Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              6 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Mar/17