Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57682

Videojs sends full lang strings for plugin on every page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Install the French language pack
      3. Make sure that javascript is cached (Go to Administration > Appearance > AJAX and Javascript and deselect the 'Cache Javascript' checkbox and save changes)
      4. Go into a course and create a page
      5. In Page content click the video link in atto
      6. Then select Video tab.
      7. Insert a small video file into the page (videoJs only accepts .fmp4, .mov, .mp4, .m4v, .ogv, .webm) formats
      8. Insert another video, now from a Youtube link.
      9. Save changes and visit the page
      10. Verify that you see 2 video players and both videos can be played
      11. Verify that the language used by the video player is English (for example when you hover over player buttons)
      12. Switch Moodle language to French
      13. Check the page that contains the videos again
      14. Verify that the language used by the video player is French (for example when you hover over player buttons)
      15. View page source
      16. Verify that it doesn't contain 'videojs.addLanguage'
      Show
      Log in as admin Install the French language pack Make sure that javascript is cached (Go to Administration > Appearance > AJAX and Javascript and deselect the 'Cache Javascript' checkbox and save changes) Go into a course and create a page In Page content click the video link in atto Then select Video tab. Insert a small video file into the page (videoJs only accepts . fmp4, .mov, .mp4, .m4v, .ogv, .webm ) formats Insert another video, now from a Youtube link . Save changes and visit the page Verify that you see 2 video players and both videos can be played Verify that the language used by the video player is English (for example when you hover over player buttons) Switch Moodle language to French Check the page that contains the videos again Verify that the language used by the video player is French (for example when you hover over player buttons) View page source Verify that it doesn't contain 'videojs.addLanguage'
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MDL-57682-310
    • Pull Master Branch:
      MDL-57682-master
    • Story Points:
      0
    • Sprint:
      International 4.0 - Sprint 3, International 4.0 - Sprint 4, International 4.0 - Sprint 5, International 4.0 - Sprint 6

      Description

      Every page now contains a huge chunk of JS params to feed the language pack to videojs.

      I have been working hard to get rid of JS bloat from every page and this is a step backwards.

      videojs.addLanguage("en",{
       "Play": "Play",
       "Pause": "Pause",
       "Current Time": "Current Time",
       "Duration Time": "Duration Time",
       "Remaining Time": "Remaining Time",
       "Stream Type": "Stream Type",
       "LIVE": "LIVE",
       "Loaded": "Loaded",
       "Progress": "Progress",
       "Fullscreen": "Fullscreen",
       "Non-Fullscreen": "Non-Fullscreen",
       "Mute": "Mute",
       "Unmute": "Unmute",
       "Playback Rate": "Playback Rate",
       "Subtitles": "Subtitles",
       "subtitles off": "subtitles off",
       "Captions": "Captions",
       "captions off": "captions off",
       "Chapters": "Chapters",
       "Close Modal Dialog": "Close Modal Dialog",
       "Descriptions": "Descriptions",
       "descriptions off": "descriptions off",
       "Audio Track": "Audio Track",
       "You aborted the media playback": "You aborted the media playback",
       "A network error caused the media download to fail part-way.": "A network error caused the media download to fail part-way.",
       "The media could not be loaded, either because the server or network failed or because the format is not supported.": "The media could not be loaded, either because the server or network failed or because the format is not supported.",
       "The media playback was aborted due to a corruption problem or because the media used features your browser did not support.": "The media playback was aborted due to a corruption problem or because the media used features your browser did not support.",
       "No compatible source was found for this media.": "No compatible source was found for this media.",
       "The media is encrypted and we do not have the keys to decrypt it.": "The media is encrypted and we do not have the keys to decrypt it.",
       "Play Video": "Play Video",
       "Close": "Close",
       "Modal Window": "Modal Window",
       "This is a modal window": "This is a modal window",
       "This modal can be closed by pressing the Escape key or activating the close button.": "This modal can be closed by pressing the Escape key or activating the close button.",
       ", opens captions settings dialog": ", opens captions settings dialog",
       ", opens subtitles settings dialog": ", opens subtitles settings dialog",
       ", opens descriptions settings dialog": ", opens descriptions settings dialog",
       ", selected": ", selected"
      });
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rezaie9 Shamim Rezaie
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Simey Lameze
              Integrator:
              Andrew Nicols
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 5 hours, 12 minutes
                  3d 5h 12m