[MDL-57742] tool_consumer_instance_guid is required when it should be optional - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

This is a simple fix and has been confirmed by two commenters below. It would take some time to set up a testing environment to replace so I think a sanity check is enough.

Show
This is a simple fix and has been confirmed by two commenters below. It would take some time to set up a testing environment to replace so I think a sanity check is enough.
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
git://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-57742~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-57742_master

This means (for example) SAKAI does not work with tools shared from moodle. We should make a pull request upstream when completing this issue. I will watch https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/19 in case it is fixed by IMS

caused a regression

MDL-62883 The LTI provider tool_consumer_instance_guid check was erroneously deleted

Participants:: CiBoT, Dave Balch, David Monllaó, John Okely, Joost van der Borg, Mark Nelson, Sebastian Berm

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias