Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57742

tool_consumer_instance_guid is required when it should be optional

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This is a simple fix and has been confirmed by two commenters below. It would take some time to set up a testing environment to replace so I think a sanity check is enough.

      Show
      This is a simple fix and has been confirmed by two commenters below. It would take some time to set up a testing environment to replace so I think a sanity check is enough.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-57742_master
    • Pull Master Diff URL:

      Description

      In the specification, tool_consumer_instance_guid is only listed as recommended. https://www.imsglobal.org/specs/ltiv2p0/implementation-guide#toc-42 However in the provider library it is required. https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/blob/master/src/ToolProvider/ToolProvider.php#L812

      This means (for example) SAKAI does not work with tools shared from moodle. We should make a pull request upstream when completing this issue. I will watch https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/19 in case it is fixed by IMS

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62883 The LTI provider tool_consumer_instance_guid check was erroneously deleted

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              balchd Dave Balch
              Reporter:
              johno John Okely
              Peer reviewer:
              Mark Nelson Mark Nelson
              Integrator:
              David Monllaó David Monllaó
              Tester:
              David Monllaó David Monllaó
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              6 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/18