[MDL-57752] tracksessionip does not allow users to re-login - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Site must be running on PHP 5.6+

Add: $CFG->tracksessionip = true; to config.php

Log in to the site

Change your IP address (depends on your OS - in Windows you can set you adapter to use a fixed IP address in your local network)

Try to visit a page on your site (but not 'Site home')

An error appears about the changed IP address and asks you to refresh the page

Refresh the page

You should now see the normal login page
Show
Site must be running on PHP 5.6+ Add: $CFG->tracksessionip = true; to config.php Log in to the site Change your IP address (depends on your OS - in Windows you can set you adapter to use a fixed IP address in your local network) Try to visit a page on your site (but not 'Site home') An error appears about the changed IP address and asks you to refresh the page Refresh the page You should now see the normal login page
Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Pull from Repository:
git://github.com/davosmith/moodle.git
Pull Master Branch:
~~MDL-57752~~_tracksessionip
Pull Master Diff URL:
https://github.com/davosmith/moodle/compare/moodle:master...MDL-57752_tracksessionip

Steps to reproduce:

Site must be running on PHP 5.6+
Add: $CFG->tracksessionip = true; to config.php
Log in to the site
Change your IP address
Try to visit a page on your site
An error appears about the changed IP address and asks you to refresh the page
Refresh the page
Instead of reaching the login page, you are presented with the changed IP address warning again

This is most noticeable when users are roaming from one wireless router to another.