[MDL-57755] Notifications automatically marked as read when messaging deactivated - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.2, 3.3.3, 3.4, 3.5.1, 3.6.4, 3.7, 3.8.1, 3.9
Fix Version/s: 3.7.5, 3.8.2
Component/s: Messages
Labels:
- ci
- openlms
- release_notes
- triaged

Affected Branches:
MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Epic Link:
Messaging issues
Pull from Repository:
https://github.com/t-schroeder/moodle
Pull Main Branch:
~~MDL-57755~~_master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...t-schroeder:MDL-57755_master
Testing Instructions:
Hide

Pre-requisite: To have at very least another user in the site, apart from admin.
1- Log in as admin
2- Check messaging system ("messaging") is disabled (in admin->advanced features on 3.5 and admin->messaging settings on 3.8)

3- Generate a notification (use one of methods below)

Generate a notification (method A):

Check that subscription mode is "forced" for site news forum

Write a news in site course and execute message task

Generate a notificacion (method B)

Create a badge with "Manual issue by role" criteria and make it available

Assign badge manually to the user

4- In another browser, login as student or teacher.
5- Check that notification icon (bell) has a badge with "1" and that last added news (or awarded badge) appears in the notification popover.
Show
Pre-requisite: To have at very least another user in the site, apart from admin. 1- Log in as admin 2- Check messaging system ("messaging") is disabled (in admin->advanced features on 3.5 and admin->messaging settings on 3.8) 3- Generate a notification (use one of methods below) Generate a notification (method A): Check that subscription mode is "forced" for site news forum Write a news in site course and execute message task Generate a notificacion (method B) Create a badge with "Manual issue by role" criteria and make it available Assign badge manually to the user 4- In another browser, login as student or teacher. 5- Check that notification icon (bell) has a badge with "1" and that last added news (or awarded badge) appears in the notification popover .

Description

Steps to reproduce:
1. Log in as admin
2. Check messaging system is enabled in admin->advanced features
3. Check that subscription mode is "forced" for site news forum
3. Write a news in site course
4. In another browser, login as student or teacher.
5. Check that notification icon (bell) has a badge with "1"
6. Mark all notifications as read.
7. As admin disable messaging system in admin->advanced features
8. Write another news in site course.
9. As student refresh your page.
10. Check that theres is no badge on notification icon (bell) but that last added news appears in the notification popover

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-01-29-08-47-34-911.png
8 kB
29/Jan/20 8:47 AM
Screen Shot 2020-01-31 at 20.28.04.png
297 kB
01/Feb/20 4:31 AM

Issue Links

has been marked as being related by

MDL-59664 When messaging is turned off on a site, notification counter is hidden in navbar.

Closed

is duplicated by

MDL-59664 When messaging is turned off on a site, notification counter is hidden in navbar.

Closed

MDL-62764 When messaging system is disabled, new notifications are not highlighted with a number in the notification menu at the top of the screen.

Closed

MDL-63404 $CFG->messaging turns off notifications as well

Closed

Testing discovered

MDL-67471 mark_notification_read fails if messaging disabled

Closed

Activity

People

Assignee:: Tim Schroeder

Reporter:: Jean-Roch Meurisse

Peer reviewer:: Ferran Recio

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: Acqua Alta, CiBoT, Eloy Lafuente (stronk7), Ferran Recio, Frank Black, Janelle Barcega, Jean-Roch Meurisse, Magyar-Hunor Tamas, Mark Nelson, Sean Young, Séverin Terrier, Tim Schroeder

Votes:: 15 Vote for this issue

Watchers:: 23 Start watching this issue

Dates

Created:: 25/Jan/17 2:38 AM

Updated:: 04/Mar/20 3:58 PM

Resolved:: 30/Jan/20 11:52 PM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Remaining:

Logged:

4h 25m