Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57786

Extra words counted in online text assignment summary count

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.1, 3.3, 3.3.3, 3.4.1, 3.5
    • Fix Version/s: 3.3.4, 3.4.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Testing instructions:

      1. As Admin create / use a Moodle Course with some students enrolled for testing
      2. Add Assignment with 'Submission Types': Online text
      3. As Admin go to Site administration > Site administration tab > Advance features
      4. Tick the 'enableportfolios' checkbox setting
      5. As Admin go to Site administration > Plugins tab > Portfolios > Manage portfolios
      6. Select the 'File download' option and set to: Enabled and visible and save
      7. As a Student submit an assignment as online text (use any text over 140 characters long)
      8. Once submitted, the Student's Assignment Submissions Status page would display a summary of the online-text submitted and provide a correct count of the words.
        • Clicking on the + link should expand the online-text and show at the bottom a hyperlink labeled "Export to portfolio" (these 3 words should not be counted in the word count).
      9. As Admin / Teacher go to the Course's Assignment > View all submissions
      10. The Online text column should show a summary of the submitted online-text and the word count should be correct (and match the same word count in Step 8 for Students).
      Show
      Testing instructions: As Admin create / use a Moodle Course with some students enrolled for testing Add Assignment with 'Submission Types': Online text As Admin go to Site administration > Site administration tab > Advance features Tick the 'enableportfolios' checkbox setting As Admin go to Site administration > Plugins tab > Portfolios > Manage portfolios Select the 'File download' option and set to: Enabled and visible and save As a Student submit an assignment as online text (use any text over 140 characters long) Once submitted, the Student's Assignment Submissions Status page would display a summary of the online-text submitted and provide a correct count of the words. Clicking on the + link should expand the online-text and show at the bottom a hyperlink labeled "Export to portfolio" (these 3 words should not be counted in the word count). As Admin / Teacher go to the Course's Assignment > View all submissions The Online text column should show a summary of the submitted online-text and the word count should be correct (and match the same word count in Step 8 for Students).
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      MDL-57786-master

      Description

      Steps to reproduce:
      1. Create Online text assignment
      2. Submit a sufficiently long submission (over 20 words)
      3. View submission summary on student or teacher side (notice that the word count displayed is higher than the actual text submission word count)

      This can cause confusion for the student and teacher: If a teacher sets a 100 word limit and a student submits exactly 100 words, the extra words counted on the summary count can make the student and teacher think that the submission is over 100 words.

      This appears to be caused by the dropdown and 'export to portfolio' button below the text being counted as words in the count_words function call. This call is in moodle/mod/assign/submission/onlinetext/locallib.php on line 368 of MOODLE_32_STABLE on January 26th, 2017.

      Possible solutions:

      • Exclude the dropdown and 'export to portfolio' button from the word count
      • Bring the dropdown and 'export to portfolio' button out of the summary area, making them always visible.

        Attachments

        1. export-truncated.png
          export-truncated.png
          110 kB
        2. MDL-57786.xlsx
          18.31 MB
        3. MDL-57786-after_bug_fix.png
          MDL-57786-after_bug_fix.png
          170 kB
        4. MDL-57786-before_bug_fix.png
          MDL-57786-before_bug_fix.png
          171 kB
        5. MDL-57786 Screen Shot 1.png
          MDL-57786 Screen Shot 1.png
          55 kB
        6. MDL-57786 Screen Shot 2.png
          MDL-57786 Screen Shot 2.png
          62 kB
        7. MDL-57786 Screen Shot 3.png
          MDL-57786 Screen Shot 3.png
          71 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/Jan/18