Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57793

Calendar repeating rule tests are a bit lame.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Run PHPUnit tests for the core_calendar_testsuite.

        vendor/bin/phpunit --testsuite core_calendar_testsuite
        

        Or if using MDK

        mdk phpunit -r -s core_calendar
        

        • Confirm that all tests pass.
      Show
      Run PHPUnit tests for the core_calendar_testsuite. vendor/bin/phpunit --testsuite core_calendar_testsuite Or if using MDK mdk phpunit -r -s core_calendar Confirm that all tests pass.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57793-master

      Description

      "These tests are also very weak - in that they test all the easy cases but none of the edge cases. I would expect to see a leap year test, 31 of november test and some DST / timezone tests. I will make a new issue about that."

      We are talking about calendar/tests/rrule_manager_test.php

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jpataleta Jun Pataleta
                Reporter:
                damyon Damyon Wiese
                Peer reviewer:
                David Monllaó
                Integrator:
                Jake Dallimore
                Tester:
                Dan Poltawski
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/May/17