Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.1.4, 3.2, 3.3, 3.4
-
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
-
MOODLE_32_STABLE, MOODLE_33_STABLE
-
MDL-57809-34-progressbar -
Description
We've found a couple prod issues which are because code is using the progress_bar() but not declaring NO_OUTPUT_BUFFERING first. So it just sits there until it's 100% and then loads without any progress. I've just done an audit and found a whole bunch of places that this affects.
I think the solution is two fold:
1) Fix the existing places to add NO_OUTPUT_BUFFERING - there are a couple places where the code is quite tangled which means this will be on for some pages that don't strictly need it, but there should be no downside here.
2) We either throw an exception (master), or log a dev error (stables), if you attempt to render a progress bar and the buffering is on
Attachments
Issue Links
- caused a regression
-
MDL-61377 Using progress_bar in an upgrade script displays debugging notice in CLI
-
- Closed
-
- has been marked as being related by
-
MDL-57810 Disable buffers in nginx when NO_OUTPUT_BUFFERING is on
-
- Closed
-
- is duplicated by
-
MDL-73643 Some quiz report screens faile when behind a reverse proxy
-
- Closed
-
- Testing discovered
-
MDL-59405 Need to document the progress classes and consider moving them to output
-
- Closed
-