Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57858

Assignment grade overview does not respect scale grades (grade = -1 should be considered as NULL)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.5, 3.2.2
    • Fix Version/s: 3.1.6, 3.2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      As admin user

      1. Create a course with a teacher and a student
      2. Create an assignment that uses grade type 'Scale' and with scale set to 'Default competencies' 
      3. Create an assignment that uses grade type 'Scale' and with scale set to 'Separate and connected ways of knowing'

      As a student:

      1. As a student, submit to both assignments

      As the teacher:

      1. Check Course Overview block (Dashboard) and Confirm that both assignments are listed as requiring attention (need to expand)
      2. Now go to the Assignment view page for each assignment and Confirm that there is one submission that requires grading for each assignment.
      3. For each assignment, go to the grading interface, and give just feedback with no grade. Save.
      4. Check both the 'Course overview' block (Dashboard) and Assignment view page and Confirm that in both cases, the assignment is listed as requiring grading still.
      Show
      As admin user Create a course with a teacher and a student Create an assignment that uses grade type 'Scale' and with scale set to 'Default competencies'  Create an assignment that uses grade type 'Scale' and with scale set to 'Separate and connected ways of knowing' As a student : As a student, submit to both assignments As the teacher : Check Course Overview block (Dashboard) and Confirm that  both assignments are listed as requiring attention (need to expand) Now go to the Assignment view page for each assignment and Confirm that there is one submission that requires grading for each assignment. For each assignment, go to the grading interface, and give just feedback with no grade. Save. Check both the 'Course overview' block (Dashboard) and Assignment view page and Confirm that in both cases, the assignment is listed as requiring grading still.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-57858-master

      Description

      Course overview block and assignment overview sometimes do not list highlight submission that require grading, while the REQUIRE_GRADING in the grading table filter does. This happens for scale grades, where grade = -1 should be treated as NULL, as it is done in grading table (gradingtable.php:307-309).

      The similar function that checks for ungraded submissions does not have this check (lib.php:783-802).
      The second place is locallib.php:1971.

      There might be other places, but i doubt so.

      I classify this as a major bug because it hides actual submission from teachers, that can affect students.

      I propose to implement this condition in both places. I might be able to work on that.

      Replication instructions:

      1. Create a course with a teacher and a student
      2. Create an assignment that uses grade scale (not point!)
      3. As a student, submit it
      4. As a teacher, check Course Overview block and Assignment view page to see that there is one submission that requires grading
      5. As a teacher, go in to grade it, and give just feedback with no grade and save.
      6. As a teacher, check both the course overview block (dashboard) and the assignment's view page and observe there is no submission that requires grading.

      Expected behaviour: there should still be a '1 submission requires grading' as the grade is not present.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/May/17